Skip to content

Commit 3c03e38

Browse files
committed
Fixes for errors and warnings
Signed-off-by: Joseph Schuchart <[email protected]>
1 parent 137346c commit 3c03e38

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

ompi/mca/osc/ucx/osc_ucx.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ typedef struct ompi_osc_ucx_module {
151151
ompi_osc_ucx_mem_ranges_t *epoc_outstanding_ops_mems;
152152
bool skip_sync_check;
153153
bool noncontig_shared_win;
154-
size_t *sizes;
155154
/* in shared windows, shmem_addrs can be used for direct load store to
156155
* remote windows */
157156
uint64_t *shmem_addrs;

ompi/mca/osc/ucx/osc_ucx_component.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ static int component_init(bool enable_progress_threads, bool enable_mpi_threads)
290290
return OMPI_SUCCESS;
291291
}
292292

293-
static int component_set_priority() {
293+
static int component_set_priority(void) {
294294
int param, ret;
295295
opal_common_ucx_support_level_t support_level = OPAL_COMMON_UCX_SUPPORT_NONE;
296296
mca_base_var_source_t param_source = MCA_BASE_VAR_SOURCE_DEFAULT;
@@ -686,7 +686,7 @@ static int component_select(struct ompi_win_t *win, void **base, size_t size, pt
686686
module->noncontig_shared_win = false;
687687
if (OMPI_SUCCESS != opal_info_get_bool(info, "alloc_shared_noncontig",
688688
&module->noncontig_shared_win, &flag)) {
689-
err = OMPI_ERR_BAD_PARAM;
689+
ret = OMPI_ERR_BAD_PARAM;
690690
goto error;
691691
}
692692

@@ -842,10 +842,10 @@ static int component_select(struct ompi_win_t *win, void **base, size_t size, pt
842842

843843

844844
for (i = 0, total = 0; i < comm_size ; ++i) {
845-
size_t size = ompi_osc_ucx_get_size(module, i);
846-
if (size || !module->noncontig_shared_win) {
845+
size_t peer_size = ompi_osc_ucx_get_size(module, i);
846+
if (peer_size || !module->noncontig_shared_win) {
847847
module->shmem_addrs[i] = ((uint64_t) module->segment_base) + total;
848-
total += size;
848+
total += peer_size;
849849
} else {
850850
module->shmem_addrs[i] = (uint64_t)NULL;
851851
}
@@ -988,7 +988,7 @@ static int component_select(struct ompi_win_t *win, void **base, size_t size, pt
988988
error:
989989
if (module->disp_units) free(module->disp_units);
990990
if (module->comm) ompi_comm_free(&module->comm);
991-
if (module->sizes) ompi_comm_free(&module->sizes);
991+
if (module->sizes) free(module->sizes);
992992
free(module);
993993
module = NULL;
994994

0 commit comments

Comments
 (0)