Skip to content

Commit 3d14955

Browse files
committed
opal/atomic: clean out s390(x)
This commit removes the CMA support for s390 and s390x. These architectures have been unsupported for awhile and no one has verified that CMA actually works with Open MPI on these systems. s390 and s390x will continue to work with Open MPI without CMA. Signed-off-by: Nathan Hjelm <[email protected]>
1 parent a0567b5 commit 3d14955

File tree

3 files changed

+3
-25
lines changed

3 files changed

+3
-25
lines changed

config/opal_config_asm.m4

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ dnl Copyright (c) 2014-2018 Los Alamos National Security, LLC. All rights
1717
dnl reserved.
1818
dnl Copyright (c) 2017 Amazon.com, Inc. or its affiliates. All Rights
1919
dnl reserved.
20+
dnl Copyright (c) 2020 Google, LLC. All rights reserved.
2021
dnl $COPYRIGHT$
2122
dnl
2223
dnl Additional copyrights may follow
@@ -1259,19 +1260,6 @@ AC_DEFUN([OPAL_CONFIG_ASM],[
12591260
fi
12601261
OPAL_GCC_INLINE_ASSIGN='"1: li %0,0" : "=&r"(ret)'
12611262
;;
1262-
# There is no current difference between s390 and s390x
1263-
# But use two different defines in case some come later
1264-
# as s390 is 31bits while s390x is 64bits
1265-
s390-*)
1266-
opal_cv_asm_arch="S390"
1267-
OPAL_CHECK_SYNC_BUILTINS([opal_cv_asm_builtin="BUILTIN_SYNC"],
1268-
[AC_MSG_ERROR([No atomic primitives available for $host])])
1269-
;;
1270-
s390x-*)
1271-
opal_cv_asm_arch="S390X"
1272-
OPAL_CHECK_SYNC_BUILTINS([opal_cv_asm_builtin="BUILTIN_SYNC"],
1273-
[AC_MSG_ERROR([No atomic primitives available for $host])])
1274-
;;
12751263
sparc*-*)
12761264
# SPARC v9 (and above) are the only ones with 64bit support
12771265
# if compiling 32 bit, see if we are v9 (aka v8plus) or

opal/include/opal/sys/architecture.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
* reserved.
1616
* Copyright (c) 2017 Research Organization for Information Science
1717
* and Technology (RIST). All rights reserved.
18+
* Copyright (c) 2020 Google, LLC. All rights reserved.
1819
* $COPYRIGHT$
1920
*
2021
* Additional copyrights may follow
@@ -42,8 +43,6 @@
4243
#define OPAL_MIPS 0070
4344
#define OPAL_ARM 0100
4445
#define OPAL_ARM64 0101
45-
#define OPAL_S390 0110
46-
#define OPAL_S390X 0111
4746
#define OPAL_BUILTIN_SYNC 0200
4847
#define OPAL_BUILTIN_GCC 0202
4948
#define OPAL_BUILTIN_NO 0203

opal/include/opal/sys/cma.h

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
* reserved.
55
* Copyright (c) 2017 Research Organization for Information Science
66
* and Technology (RIST). All rights reserved.
7+
* Copyright (c) 2020 Google, LLC. All rights reserved.
78
* $COPYRIGHT$
89
*/
910

@@ -82,16 +83,6 @@
8283

8384
#endif
8485

85-
#elif OPAL_ASSEMBLY_ARCH == OPAL_S390
86-
87-
#define __NR_process_vm_readv 340
88-
#define __NR_process_vm_writev 341
89-
90-
#elif OPAL_ASSEMBLY_ARCH == OPAL_S390X
91-
92-
#define __NR_process_vm_readv 340
93-
#define __NR_process_vm_writev 341
94-
9586
#else
9687
#error "Unsupported architecture for process_vm_readv and process_vm_writev syscalls"
9788
#endif

0 commit comments

Comments
 (0)