Skip to content

Commit 3eae0ee

Browse files
committed
io/ompio: change default for sharedfp_lazy_open parameter
Revert the logic of io_ompio_sharedfp_lazy_open. The user now has to explicitely disable shared fp in order for the structures not to be allocated. Otherwise, resetting the shared fp e.g. in case the file was opened in append mode will not work correctly, the code could deadlock. Signed-off-by: Edgar Gabriel <[email protected]>
1 parent d3a8d38 commit 3eae0ee

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ompi/mca/io/ompio/io_ompio_component.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ int mca_io_ompio_bytes_per_agg = OMPIO_PREALLOC_MAX_BUF_SIZE;
3636
int mca_io_ompio_num_aggregators = -1;
3737
int mca_io_ompio_record_offset_info = 0;
3838
int mca_io_ompio_coll_timing_info = 0;
39-
int mca_io_ompio_sharedfp_lazy_open = 1;
39+
int mca_io_ompio_sharedfp_lazy_open = 0;
4040

4141
int mca_io_ompio_grouping_option=5;
4242

@@ -193,7 +193,7 @@ static int register_component(void)
193193
&mca_io_ompio_num_aggregators);
194194

195195

196-
mca_io_ompio_sharedfp_lazy_open = 1;
196+
mca_io_ompio_sharedfp_lazy_open = 0;
197197
(void) mca_base_component_var_register(&mca_io_ompio_component.io_version,
198198
"sharedfp_lazy_open",
199199
"lazy allocation of internal shared file pointer structures",

0 commit comments

Comments
 (0)