Skip to content

Commit 44c97e3

Browse files
committed
Update again and hope to fix the integration points
Signed-off-by: Ralph Castain <[email protected]>
1 parent 8615761 commit 44c97e3

File tree

4 files changed

+20
-18
lines changed

4 files changed

+20
-18
lines changed

config/ompi_setup_prrte.m4

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -62,32 +62,37 @@ AC_DEFUN([OMPI_SETUP_PRRTE],[
6262
if test "$enable_internal_rte" != "no"; then
6363
AC_MSG_RESULT([yes])
6464
ompi_want_prrte=yes
65-
opal_prrte_extra_ldflags=
6665
opal_prrte_extra_libs=$OMPI_TOP_BUILDDIR/opal/libopen-pal.la
6766
opal_prrte_extra_ltlibs=$OMPI_TOP_BUILDDIR/opal/libopen-pal.la
6867

6968
if test -z $with_libevent || test "$with_libevent" = "internal" || test "$with_libevent" = "yes"; then
7069
opal_prrte_libevent_arg="--with-libevent-header=$OMPI_TOP_SRCDIR/opal/mca/event/event.h"
71-
elif test "$with_libevent" = "external"; then
72-
opal_prrte_libevent_arg=""
7370
else
74-
opal_prrte_libevent_arg="--with-libevent=$with_libevent"
71+
if test "$with_libevent" = "external"; then
72+
opal_prrte_libevent_arg="--with-libevent"
73+
else
74+
opal_prrte_libevent_arg="--with-libevent=$with_libevent"
75+
fi
7576
fi
7677

7778
if test -z $with_hwloc || test "$with_hwloc" = "internal" || test "$with_hwloc" = "yes"; then
7879
opal_prrte_hwloc_arg="--with-hwloc-header=$OMPI_TOP_SRCDIR/opal/mca/hwloc/hwloc-internal.h"
79-
elif test "$with_hwloc" = "external"; then
80-
opal_prrte_hwloc_arg=""
8180
else
82-
opal_prrte_hwloc_arg="--with-hwloc=$with_hwloc"
81+
if test "$with_hwloc" = "external"; then
82+
opal_prrte_hwloc_arg="--with-hwloc"
83+
else
84+
opal_prrte_hwloc_arg="--with-hwloc=$with_hwloc"
85+
fi
8386
fi
8487

8588
if test -z $with_pmix || test "$with_pmix" = "internal" || test "$with_pmix" = "yes"; then
8689
opal_prrte_pmix_arg="--with-pmix-header=$OMPI_TOP_SRCDIR/opal/mca/pmix/pmix-internal.h"
87-
elif test "$with_pmix" = "external"; then
88-
opal_prrte_pmix_arg=""
8990
else
90-
opal_prrte_pmix_arg="--with-pmix=$with_pmix"
91+
if test "$with_pmix" = "external"; then
92+
opal_prrte_pmix_arg="--with-pmix"
93+
else
94+
opal_prrte_pmix_arg="--with-pmix=$with_pmix"
95+
fi
9196
fi
9297

9398
if test -z $enable_prte_prefix_by_default || test "$enable_prte_prefix_by_default" = "yes" ||
@@ -109,11 +114,7 @@ AC_DEFUN([OMPI_SETUP_PRRTE],[
109114
opal_prrte_args="$opal_prrte_args --with-platform=$with_prrte_platform"
110115
fi
111116
# add the extra libs
112-
if test "x$opal_prrte_extra_ldflags" != "x"; then
113-
opal_prrte_args="$opal_prrte_args --with-prrte-extra-ldflags=\"$opal_prrte_extra_ldflags\" --with-prrte-extra-lib=\"$opal_prrte_extra_libs\" --with-prrte-extra-ltlib=\"$opal_prrte_extra_ltlibs\""
114-
else
115-
opal_prrte_args="$opal_prrte_args --with-prrte-extra-lib=\"$opal_prrte_extra_libs\" --with-prrte-extra-ltlib=\"$opal_prrte_extra_ltlibs\""
116-
fi
117+
opal_prrte_args="$opal_prrte_args --with-prrte-extra-lib=\"$opal_prrte_extra_libs\" --with-prrte-extra-ltlib=\"$opal_prrte_extra_ltlibs\""
117118

118119
AC_MSG_CHECKING([final prrte configure args])
119120
AC_MSG_RESULT([$opal_prrte_args])

config/opal_config_asm.m4

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ dnl reserved.
1818
dnl Copyright (c) 2017 Amazon.com, Inc. or its affiliates. All Rights
1919
dnl reserved.
2020
dnl Copyright (c) 2020 Google, LLC. All rights reserved.
21+
dnl Copyright (c) 2020 Intel, Inc. All rights reserved.
2122
dnl $COPYRIGHT$
2223
dnl
2324
dnl Additional copyrights may follow
@@ -833,7 +834,7 @@ AC_DEFUN([OPAL_CHECK_ASM_GNU_STACKEXEC], [
833834
int testfunc() {return 0; }
834835
EOF
835836
OPAL_LOG_COMMAND([$CC $CFLAGS -c conftest.c -o conftest.$OBJEXT],
836-
[$OBJDUMP -x conftest.$OBJEXT | $GREP '\.note\.GNU-stack' > /dev/null && opal_cv_asm_gnu_stack_result=yes],
837+
[$OBJDUMP -x conftest.$OBJEXT 2>&1 | $GREP '\.note\.GNU-stack' &> /dev/null && opal_cv_asm_gnu_stack_result=yes],
837838
[OPAL_LOG_MSG([the failed program was:], 1)
838839
OPAL_LOG_FILE([conftest.c])
839840
opal_cv_asm_gnu_stack_result=no])

0 commit comments

Comments
 (0)