topo/treematch: fix CID 1416327

jsquyres · jsquyres · commit 536003599541 · 2018-03-26T14:26:17.000-07:00
Ensure to free things in the right order so that we don't access
memory after it is freed.

Signed-off-by: Jeff Squyres &lt;jsquyres@cisco.com&gt;
diff --git a/ompi/mca/topo/treematch/treematch/tm_tree.c b/ompi/mca/topo/treematch/treematch/tm_tree.c
@@ -132,8 +132,8 @@ void free_non_constraint_tree(tm_tree_t *tree)
 {
   int d = tree->dumb;
 
-  free_list_child(tree);
   free_tab_child(tree);
+  free_list_child(tree);
   if(!d)
     FREE(tree);
 }

Original file line number	Diff line number	Diff line change
`@@ -132,8 +132,8 @@ void free_non_constraint_tree(tm_tree_t *tree)`
`132`	`132`	`{`
`133`	`133`	`int d = tree->dumb;`
`134`	`134`
`135`		`- free_list_child(tree);`
`136`	`135`	`free_tab_child(tree);`
	`136`	`+ free_list_child(tree);`
`137`	`137`	`if(!d)`
`138`	`138`	`FREE(tree);`
`139`	`139`	`}`