Skip to content

Commit 5408bab

Browse files
committed
sessions: fix arg checking for group_from_session_pset
The group handle to MPI_Group_from_session_pset is an OUT parameter as defined in the MPI 4.0 spec. The spec is silent about what the value pointed to by the group handle argument can/should be. Note the second example in section 11.4 of the specification fails unless this patch is applied. Related to issue #10577 Signed-off-by: Howard Pritchard <[email protected]>
1 parent 267b119 commit 5408bab

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

ompi/instance/instance.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1310,14 +1310,11 @@ int ompi_group_from_pset (ompi_instance_t *instance, const char *pset_name, ompi
13101310
if (NULL == group_out) {
13111311
return OMPI_ERR_BAD_PARAM;
13121312
}
1313-
if (*group_out == MPI_GROUP_NULL) {
1314-
return OMPI_ERR_BAD_PARAM;
1315-
}
1316-
1313+
13171314
if (0 == strncmp (pset_name, "mpi://", 6)) {
13181315
pset_name += 6;
13191316
if (0 == strcasecmp (pset_name, "WORLD")) {
1320-
return ompi_instance_group_world (instance, group_out);
1317+
return ompi_instance_group_world (instance, group_out);
13211318
}
13221319
if (0 == strcasecmp (pset_name, "SELF")) {
13231320
return ompi_instance_group_self (instance, group_out);

0 commit comments

Comments
 (0)