fs/gpfs: Assign file creation to one process and management of error codes translation.

When O_CREAT and O_EXCL are set, open() shall fail if the file exists. Therefore, I assigned the file creation to the root process only.
I also translated the errno codes to their corresponding MPI error codes.

Signed-off-by: raafatfeki <[email protected]>

Author: raafatfeki

ompi/mca/fs/gpfs/fs_gpfs.c

@@ -138,3 +138,43 @@ int mca_fs_gpfs_module_finalize (ompio_file_t *file)
 {
     return OMPI_SUCCESS;
 }
+
+int
+mca_fs_gpfs_file_get_mpi_err (int errno_val)
+{
+    int ret;
+    switch (errno_val) {
+        case EACCES:
+            ret = MPI_ERR_ACCESS;
+            break;
+	case EISDIR:
+        case ENAMETOOLONG:
+            ret = MPI_ERR_BAD_FILE;
+            break;
+        case ENOENT:
+            ret = MPI_ERR_NO_SUCH_FILE;
+            break;
+        case EROFS:
+            ret = MPI_ERR_READ_ONLY;
+            break;
+        case EEXIST:
+            ret = MPI_ERR_FILE_EXISTS;
+            break;
+        case ENOSPC:
+            ret = MPI_ERR_NO_SPACE;
+            break;
+        case EDQUOT:
+            ret = MPI_ERR_QUOTA;
+            break;
+        case ETXTBSY:
+            ret = MPI_ERR_FILE_IN_USE;
+            break;
+        case EBADF:
+            ret = MPI_ERR_FILE;
+            break;
+        default:
+            ret = MPI_ERR_OTHER;
+            break;
+    }
+    return ret;
+}

ompi/mca/fs/gpfs/fs_gpfs.h

@@ -74,6 +74,8 @@ int
 mca_fs_gpfs_file_get_position(struct ompi_file_t *fh,
 		OMPI_MPI_OFFSET_TYPE *offset);
 
+int mca_fs_gpfs_file_get_mpi_err (int errno_val);
+
 /*
  * ******************************************************************
  * ************ functions implemented in this module end ************

ompi/mca/fs/gpfs/fs_gpfs_file_open.c

@@ -48,6 +48,7 @@ mca_fs_gpfs_file_open (struct ompi_communicator_t *comm,
 {
     int amode;
     int old_mask, perm;
+    int ret = OMPI_SUCCESS;
 
     if (fh->f_perm == OMPIO_PERM_NULL)  {
         old_mask = umask(022);
@@ -60,9 +61,6 @@ mca_fs_gpfs_file_open (struct ompi_communicator_t *comm,
 
     amode = 0;
 
-    if (access_mode & MPI_MODE_CREATE) {
-        amode = amode | O_CREAT;
-    }
     if (access_mode & MPI_MODE_RDONLY) {
         amode = amode | O_RDONLY;
     }
@@ -72,15 +70,33 @@ mca_fs_gpfs_file_open (struct ompi_communicator_t *comm,
     if (access_mode & MPI_MODE_RDWR) {
         amode = amode | O_RDWR;
     }
-    if (access_mode & MPI_MODE_EXCL) {
-        amode = amode | O_EXCL;
+
+    if(OMPIO_ROOT == fh->f_rank) {
+        if (access_mode & MPI_MODE_CREATE) {
+            amode = amode | O_CREAT;
+        }
+        if (access_mode & MPI_MODE_EXCL) {
+            amode = amode | O_EXCL;
+        }
+
+        fh->fd = open (filename, amode, perm);
+
+        if ( 0 > fh->fd ) {
+            ret = mca_fs_gpfs_file_get_mpi_err(errno);
+        }
     }
 
-    //DEBUG: fprintf(stderr, "Opening a file using Linux open() within fs_gpfs_file_open\n");
+    comm->c_coll->coll_bcast ( &ret, 1, MPI_INT, 0, comm, comm->c_coll->coll_bcast_module);
+    if ( OMPI_SUCCESS != ret ) {
+        fh->fd = -1;
+        return ret;
+    }
 
-    fh->fd = open (filename, amode, perm);
-    if (-1 == fh->fd) {
-        return OMPI_ERROR;
+    if ( OMPIO_ROOT != fh->f_rank ) {
+        fh->fd = open (filename, amode, perm);
+        if ( 0 > fh->fd) {
+            return mca_fs_gpfs_file_get_mpi_err(errno);
+        }
     }
 
     fh->f_amode=access_mode;