Merge pull request #4051 from rhc54/topic/cov

Ralph Castain · web-flow · commit 628b4f7add8c · 2017-08-08T07:02:40.000-07:00
Silence coverity warnings
diff --git a/opal/mca/pmix/pmix2x/pmix2x_client.c b/opal/mca/pmix/pmix2x/pmix2x_client.c
@@ -80,6 +80,7 @@ int pmix2x_client_init(opal_list_t *ilist)
         }
         /* check the evars for a mismatch */
         if (OPAL_SUCCESS != (dbg = opal_pmix_pmix2x_check_evars())) {
+            OPAL_PMIX_RELEASE_THREAD(&opal_pmix_base.lock);
             return dbg;
         }
     }
diff --git a/opal/mca/pmix/pmix2x/pmix2x_server_south.c b/opal/mca/pmix/pmix2x/pmix2x_server_south.c
@@ -110,6 +110,7 @@ int pmix2x_server_init(opal_pmix_server_module_t *module,
         }
         /* check the evars for a mismatch */
         if (OPAL_SUCCESS != (dbg = opal_pmix_pmix2x_check_evars())) {
+            OPAL_PMIX_RELEASE_THREAD(&opal_pmix_base.lock);
             return dbg;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,7 @@ int pmix2x_client_init(opal_list_t *ilist)`
`80`	`80`	`}`
`81`	`81`	`/* check the evars for a mismatch */`
`82`	`82`	`if (OPAL_SUCCESS != (dbg = opal_pmix_pmix2x_check_evars())) {`
	`83`	`+ OPAL_PMIX_RELEASE_THREAD(&opal_pmix_base.lock);`
`83`	`84`	`return dbg;`
`84`	`85`	`}`
`85`	`86`	`}`
Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,7 @@ int pmix2x_server_init(opal_pmix_server_module_t *module,`
`110`	`110`	`}`
`111`	`111`	`/* check the evars for a mismatch */`
`112`	`112`	`if (OPAL_SUCCESS != (dbg = opal_pmix_pmix2x_check_evars())) {`
	`113`	`+ OPAL_PMIX_RELEASE_THREAD(&opal_pmix_base.lock);`
`113`	`114`	`return dbg;`
`114`	`115`	`}`
`115`	`116`	`}`