Skip to content

Commit 640f781

Browse files
committed
pmix/ext2x: fix support for external PMIx v3.1
The PMIX_MODEX and PMIX_INFO_ARRAY macros were removed from the PMIx 3.1 standard. Open MPI does not really need them (they are only used to be reported as not supported), so smply #ifdef protect them to support an external PMIx v3.1 external PMIx v3 is supported via the pmix/ext2x component, and it has worked so far until PMIx v3.1 removed some macros, the change to support external PMIx v3.1 is minimal, so we do not need to bother creating a new pmix/ext3x component. The change only need to be done in ext2x/ext2x.c. But since this file is automatically generated from pmix2x/pmix2x.c, we have to update the latter file. Refs. #6247 Signed-off-by: Gilles Gouaillardet <[email protected]> (back-ported from commit 950ba16)
1 parent 0e27b42 commit 640f781

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

opal/mca/pmix/pmix2x/pmix2x.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
22
/*
33
* Copyright (c) 2014-2018 Intel, Inc. All rights reserved.
4-
* Copyright (c) 2014-2017 Research Organization for Information Science
5-
* and Technology (RIST). All rights reserved.
4+
* Copyright (c) 2014-2019 Research Organization for Information Science
5+
* and Technology (RIST). All rights reserved.
66
* Copyright (c) 2014-2015 Mellanox Technologies, Inc.
77
* All rights reserved.
88
* Copyright (c) 2016 Cisco Systems, Inc. All rights reserved.
@@ -1001,10 +1001,12 @@ int pmix2x_value_unload(opal_value_t *kv,
10011001
OPAL_ERROR_LOG(OPAL_ERR_NOT_SUPPORTED);
10021002
rc = OPAL_ERR_NOT_SUPPORTED;
10031003
break;
1004+
#ifdef PMIX_MODEX
10041005
case PMIX_MODEX:
10051006
OPAL_ERROR_LOG(OPAL_ERR_NOT_SUPPORTED);
10061007
rc = OPAL_ERR_NOT_SUPPORTED;
10071008
break;
1009+
#endif /* PMIX_MODEX */
10081010
case PMIX_PERSIST:
10091011
kv->type = OPAL_PERSIST;
10101012
kv->data.uint8 = pmix2x_convert_persist(v->data.persist);
@@ -1111,10 +1113,12 @@ int pmix2x_value_unload(opal_value_t *kv,
11111113
OPAL_ERROR_LOG(OPAL_ERR_NOT_SUPPORTED);
11121114
rc = OPAL_ERR_NOT_SUPPORTED;
11131115
break;
1116+
#ifdef PMIX_INFO_ARRAY
11141117
case PMIX_INFO_ARRAY:
11151118
OPAL_ERROR_LOG(OPAL_ERR_NOT_SUPPORTED);
11161119
rc = OPAL_ERR_NOT_SUPPORTED;
11171120
break;
1121+
#endif /* PMIX_INFO_ARRAY */
11181122

11191123
default:
11201124
/* silence warnings */

0 commit comments

Comments
 (0)