Skip to content

Commit 65618f8

Browse files
committed
COLL/TUNED: Minor var names/comments fixes
Signed-off-by: Mikhail Brinskii <[email protected]>
1 parent 404c480 commit 65618f8

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

ompi/mca/coll/tuned/coll_tuned.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ extern int ompi_coll_tuned_alltoall_small_msg;
4040
extern int ompi_coll_tuned_alltoall_intermediate_msg;
4141
extern int ompi_coll_tuned_alltoall_large_msg;
4242
extern int ompi_coll_tuned_alltoall_min_procs;
43-
extern int ompi_coll_tuned_alltoall_max_reqs;
43+
extern int ompi_coll_tuned_alltoall_max_requests;
4444

4545
/* forced algorithm choices */
4646
/* this structure is for storing the indexes to the forced algorithm mca params... */

ompi/mca/coll/tuned/coll_tuned_alltoall_decision.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,15 +116,15 @@ int ompi_coll_tuned_alltoall_intra_check_forced_init (coll_tuned_force_algorithm
116116

117117
(void) mca_base_component_var_register(&mca_coll_tuned_component.super.collm_version,
118118
"alltoall_large_msg",
119-
"threshold (if supported) to decide if large MSGs alltoall algorithm will be used",
119+
"use pairwise exchange algorithm for messages larger than this value",
120120
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
121121
OPAL_INFO_LVL_6,
122122
MCA_BASE_VAR_SCOPE_READONLY,
123123
&ompi_coll_tuned_alltoall_large_msg);
124124

125125
(void) mca_base_component_var_register(&mca_coll_tuned_component.super.collm_version,
126126
"alltoall_min_procs",
127-
"threshold (if supported) to decide if many processes alltoall algorithm will be used",
127+
"use pairwise exchange algorithm for communicators larger than this value",
128128
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
129129
OPAL_INFO_LVL_6,
130130
MCA_BASE_VAR_SCOPE_READONLY,
@@ -137,16 +137,16 @@ int ompi_coll_tuned_alltoall_intra_check_forced_init (coll_tuned_force_algorithm
137137
MCA_BASE_VAR_TYPE_INT, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
138138
OPAL_INFO_LVL_5,
139139
MCA_BASE_VAR_SCOPE_ALL,
140-
&ompi_coll_tuned_alltoall_max_reqs);
140+
&ompi_coll_tuned_alltoall_max_requests);
141141
if (mca_param_indices->max_requests_param_index < 0) {
142142
return mca_param_indices->max_requests_param_index;
143143
}
144144

145-
if (ompi_coll_tuned_alltoall_max_reqs < 0) {
145+
if (ompi_coll_tuned_alltoall_max_requests < 0) {
146146
if( 0 == ompi_comm_rank( MPI_COMM_WORLD ) ) {
147147
opal_output( 0, "Maximum outstanding requests must be positive number greater than 1. Switching to 0 \n");
148148
}
149-
ompi_coll_tuned_alltoall_max_reqs = 0;
149+
ompi_coll_tuned_alltoall_max_requests = 0;
150150
}
151151

152152
return (MPI_SUCCESS);

ompi/mca/coll/tuned/coll_tuned_component.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,12 @@ int ompi_coll_tuned_init_max_requests = 128;
5757
int ompi_coll_tuned_alltoall_small_msg = 200;
5858
int ompi_coll_tuned_alltoall_intermediate_msg = 3000;
5959

60-
/* Set it to intermediate value by default, so it does not affect default
61-
* algorithm selection. Changing this value will force using linear with sync
62-
* algorithm on certain message sizes. */
60+
/* Set it to the same value as intermediate msg by default, so it does not affect
61+
* default algorithm selection. Changing this value will force using linear with
62+
* sync algorithm on certain message sizes. */
6363
int ompi_coll_tuned_alltoall_large_msg = 3000;
64-
int ompi_coll_tuned_alltoall_min_procs = 0; /* not used by default */
65-
int ompi_coll_tuned_alltoall_max_reqs = 0; /* no limit for alltoall by default */
64+
int ompi_coll_tuned_alltoall_min_procs = 0; /* disable by default */
65+
int ompi_coll_tuned_alltoall_max_requests = 0; /* no limit for alltoall by default */
6666

6767
/* forced alogrithm variables */
6868
/* indices for the MCA parameters */

ompi/mca/coll/tuned/coll_tuned_decision_fixed.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ int ompi_coll_tuned_alltoall_intra_dec_fixed(const void *sbuf, int scount,
141141
return ompi_coll_base_alltoall_intra_linear_sync(sbuf, scount, sdtype,
142142
rbuf, rcount, rdtype,
143143
comm, module,
144-
ompi_coll_tuned_alltoall_max_reqs);
144+
ompi_coll_tuned_alltoall_max_requests);
145145
}
146146

147147
return ompi_coll_base_alltoall_intra_pairwise(sbuf, scount, sdtype,

0 commit comments

Comments
 (0)