Skip to content

Commit 71de03f

Browse files
author
Ralph Castain
committed
Cleanup the new naming requirements to ensure that info is correctly retrieved
Cleanup permissions Restore singleton operations
1 parent 58e9cac commit 71de03f

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

opal/mca/pmix/pmix2x/pmix/src/client/pmix_client_get.c

100755100644
File mode changed.

opal/mca/pmix/pmix2x/pmix/src/server/pmix_server_get.c

100755100644
File mode changed.

orte/mca/ess/pmi/ess_pmi_module.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ static int rte_init(void)
139139
/* setup a name for retrieving data associated with the job */
140140
name.jobid = ORTE_PROC_MY_NAME->jobid;
141141
name.vpid = ORTE_NAME_WILDCARD->vpid;
142-
142+
143143
/* get our local rank from PMI */
144144
OPAL_MODEX_RECV_VALUE(ret, OPAL_PMIX_LOCAL_RANK,
145145
ORTE_PROC_MY_NAME, &u16ptr, OPAL_UINT16);
@@ -203,7 +203,7 @@ static int rte_init(void)
203203
/* get the number of local peers - required for wireup of
204204
* shared memory BTL */
205205
OPAL_MODEX_RECV_VALUE(ret, OPAL_PMIX_LOCAL_SIZE,
206-
ORTE_PROC_MY_NAME, &u32ptr, OPAL_UINT32);
206+
&name, &u32ptr, OPAL_UINT32);
207207
if (OPAL_SUCCESS == ret) {
208208
orte_process_info.num_local_peers = u32 - 1; // want number besides ourselves
209209
} else {
@@ -234,7 +234,7 @@ static int rte_init(void)
234234
/* retrieve our topology */
235235
val = NULL;
236236
OPAL_MODEX_RECV_VALUE_OPTIONAL(ret, OPAL_PMIX_LOCAL_TOPO,
237-
ORTE_PROC_MY_NAME, &val, OPAL_STRING);
237+
&name, &val, OPAL_STRING);
238238
if (OPAL_SUCCESS == ret && NULL != val) {
239239
/* load the topology */
240240
if (0 != hwloc_topology_init(&opal_hwloc_topology)) {
@@ -293,7 +293,7 @@ static int rte_init(void)
293293
error = "topology export";
294294
goto error;
295295
}
296-
if (OPAL_SUCCESS != (ret = opal_pmix.store_local(ORTE_PROC_MY_NAME, kv))) {
296+
if (OPAL_SUCCESS != (ret = opal_pmix.store_local(&name, kv))) {
297297
error = "topology store";
298298
goto error;
299299
}
@@ -310,12 +310,12 @@ static int rte_init(void)
310310
}
311311
/* retrieve the local peers */
312312
OPAL_MODEX_RECV_VALUE(ret, OPAL_PMIX_LOCAL_PEERS,
313-
ORTE_PROC_MY_NAME, &val, OPAL_STRING);
313+
&name, &val, OPAL_STRING);
314314
if (OPAL_SUCCESS == ret && NULL != val) {
315315
peers = opal_argv_split(val, ',');
316316
free(val);
317317
/* and their cpusets, if available */
318-
OPAL_MODEX_RECV_VALUE_OPTIONAL(ret, OPAL_PMIX_LOCAL_CPUSETS, ORTE_PROC_MY_NAME, &val, OPAL_STRING);
318+
OPAL_MODEX_RECV_VALUE_OPTIONAL(ret, OPAL_PMIX_LOCAL_CPUSETS, &name, &val, OPAL_STRING);
319319
if (OPAL_SUCCESS == ret && NULL != val) {
320320
cpusets = opal_argv_split(val, ':');
321321
free(val);

orte/mca/ess/singleton/ess_singleton_module.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ static int rte_init(void)
9090
char *val;
9191
int u32, *u32ptr;
9292
uint16_t u16, *u16ptr;
93+
orte_process_name_t name;
9394

9495
/* run the prolog */
9596
if (ORTE_SUCCESS != (rc = orte_ess_base_std_prolog())) {
@@ -198,6 +199,8 @@ static int rte_init(void)
198199
* so carry it forward here */
199200
ORTE_PROC_MY_NAME->jobid = OPAL_PROC_MY_NAME.jobid;
200201
ORTE_PROC_MY_NAME->vpid = OPAL_PROC_MY_NAME.vpid;
202+
name.jobid = OPAL_PROC_MY_NAME.jobid;
203+
name.vpid = ORTE_VPID_WILDCARD;
201204

202205
/* get our local rank from PMI */
203206
OPAL_MODEX_RECV_VALUE(ret, OPAL_PMIX_LOCAL_RANK,
@@ -219,7 +222,7 @@ static int rte_init(void)
219222

220223
/* get max procs */
221224
OPAL_MODEX_RECV_VALUE(ret, OPAL_PMIX_MAX_PROCS,
222-
ORTE_PROC_MY_NAME, &u32ptr, OPAL_UINT32);
225+
&name, &u32ptr, OPAL_UINT32);
223226
if (OPAL_SUCCESS != ret) {
224227
error = "getting max procs";
225228
goto error;
@@ -274,7 +277,7 @@ static int rte_init(void)
274277

275278
/* retrieve our topology */
276279
OPAL_MODEX_RECV_VALUE(ret, OPAL_PMIX_LOCAL_TOPO,
277-
ORTE_PROC_MY_NAME, &val, OPAL_STRING);
280+
&name, &val, OPAL_STRING);
278281
if (OPAL_SUCCESS == ret && NULL != val) {
279282
/* load the topology */
280283
if (0 != hwloc_topology_init(&opal_hwloc_topology)) {

0 commit comments

Comments
 (0)