Skip to content

Commit 7d493c6

Browse files
committed
Uniform conditions in ob1 recv
In ob1 we have four similar conditions but they are not written in a uniform way Signed-off-by: Julien EMMANUEL <[email protected]>
1 parent 208c2d2 commit 7d493c6

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

ompi/mca/pml/ob1/pml_ob1_irecv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ int mca_pml_ob1_recv(void *addr,
134134
MCA_PML_OB1_RECV_REQUEST_START(recvreq);
135135
ompi_request_wait_completion(&recvreq->req_recv.req_base.req_ompi);
136136

137-
if( true == recvreq->req_recv.req_base.req_pml_complete ) {
137+
if (recvreq->req_recv.req_base.req_pml_complete) {
138138
/* make buffer defined when the request is completed */
139139
MEMCHECKER(
140140
memchecker_call(&opal_memchecker_base_mem_defined,

ompi/mca/pml/ob1/pml_ob1_recvreq.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ static int mca_pml_ob1_recv_request_free(struct ompi_request_t** request)
8080
PERUSE_TRACE_COMM_EVENT( PERUSE_COMM_REQ_NOTIFY,
8181
&(recvreq->req_recv.req_base), PERUSE_RECV );
8282

83-
if( true == recvreq->req_recv.req_base.req_pml_complete ) {
83+
if (recvreq->req_recv.req_base.req_pml_complete) {
8484
/* make buffer defined when the request is completed,
8585
and before releasing the objects. */
8686
MEMCHECKER(
@@ -105,7 +105,7 @@ static int mca_pml_ob1_recv_request_cancel(struct ompi_request_t* ompi_request,
105105

106106
/* The rest should be protected behind the match logic lock */
107107
OB1_MATCHING_LOCK(&ob1_comm->matching_lock);
108-
if( true == request->req_match_received ) { /* way to late to cancel this one */
108+
if (request->req_match_received) { /* way to late to cancel this one */
109109
OB1_MATCHING_UNLOCK(&ob1_comm->matching_lock);
110110
assert( OMPI_ANY_TAG != ompi_request->req_status.MPI_TAG ); /* not matched isn't it */
111111
return OMPI_SUCCESS;

ompi/mca/pml/ob1/pml_ob1_sendreq.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ static int mca_pml_ob1_send_request_free(struct ompi_request_t** request)
106106
PERUSE_TRACE_COMM_EVENT( PERUSE_COMM_REQ_NOTIFY,
107107
&(sendreq->req_send.req_base), PERUSE_SEND );
108108

109-
if( true == sendreq->req_send.req_base.req_pml_complete ) {
109+
if (sendreq->req_send.req_base.req_pml_complete) {
110110
/* make buffer defined when the request is completed,
111111
and before releasing the objects. */
112112
MEMCHECKER(

0 commit comments

Comments
 (0)