Skip to content

Commit 827a2bc

Browse files
authored
Merge pull request #6852 from wckzhang/opalifnamesize
opal/util: Change opal/util/if.h macro IF_NAMESIZE to OPAL_IF_NAMESIZE
2 parents 385da4e + 4ebb37a commit 827a2bc

File tree

13 files changed

+26
-20
lines changed

13 files changed

+26
-20
lines changed

contrib/build-mca-comps-outside-of-tree/btl_tcp2_component.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ static char **split_and_resolve(char **orig_str, char *name)
401401
{
402402
int i, ret, save, if_index;
403403
char **argv, *str, *tmp;
404-
char if_name[IF_NAMESIZE];
404+
char if_name[OPAL_IF_NAMESIZE];
405405
struct sockaddr_storage argv_inaddr, if_inaddr;
406406
uint32_t argv_prefix;
407407

@@ -593,8 +593,8 @@ static int mca_btl_tcp2_component_create_instances(void)
593593
{
594594
int i;
595595
for(i = 0; i < kif_count; i++) {
596-
/* IF_NAMESIZE is defined in opal/util/if.h */
597-
char if_name[IF_NAMESIZE];
596+
/* OPAL_IF_NAMESIZE is defined in opal/util/if.h */
597+
char if_name[OPAL_IF_NAMESIZE];
598598
if_index = kindexes[i];
599599

600600
opal_ifkindextoname(if_index, if_name, sizeof(if_name));

contrib/build-mca-comps-outside-of-tree/btl_tcp2_proc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ static void mca_btl_tcp2_initialise_interface(mca_btl_tcp2_interface_t* interfac
235235
static mca_btl_tcp2_interface_t** mca_btl_tcp2_retrieve_local_interfaces(void)
236236
{
237237
struct sockaddr_storage local_addr;
238-
char local_if_name[IF_NAMESIZE];
238+
char local_if_name[OPAL_IF_NAMESIZE];
239239
char **include, **exclude, **argv;
240240
int idx;
241241

opal/mca/btl/tcp/btl_tcp_component.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@ static char **split_and_resolve(char **orig_str, char *name, bool reqd)
622622
{
623623
int i, ret, save, if_index;
624624
char **argv, *str, *tmp;
625-
char if_name[IF_NAMESIZE];
625+
char if_name[OPAL_IF_NAMESIZE];
626626
struct sockaddr_storage argv_inaddr, if_inaddr;
627627
uint32_t argv_prefix;
628628

@@ -821,8 +821,8 @@ static int mca_btl_tcp_component_create_instances(void)
821821
{
822822
int i;
823823
for(i = 0; i < kif_count; i++) {
824-
/* IF_NAMESIZE is defined in opal/util/if.h */
825-
char if_name[IF_NAMESIZE];
824+
/* OPAL_IF_NAMESIZE is defined in opal/util/if.h */
825+
char if_name[OPAL_IF_NAMESIZE];
826826
if_index = kindexes[i];
827827

828828
opal_ifkindextoname(if_index, if_name, sizeof(if_name));

opal/mca/btl/tcp/btl_tcp_proc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ static void mca_btl_tcp_initialise_interface(mca_btl_tcp_interface_t* tcp_interf
295295
static mca_btl_tcp_interface_t** mca_btl_tcp_retrieve_local_interfaces(mca_btl_tcp_proc_data_t *proc_data)
296296
{
297297
struct sockaddr_storage local_addr;
298-
char local_if_name[IF_NAMESIZE];
298+
char local_if_name[OPAL_IF_NAMESIZE];
299299
char **include, **exclude, **argv;
300300
int idx;
301301
mca_btl_tcp_interface_t * local_interface;

opal/mca/if/bsdx_ipv4/if_bsdx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ static int if_bsdx_open(void)
126126
/* fill values into the opal_if_t */
127127
memcpy(&a4, &(sin_addr->sin_addr), sizeof(struct in_addr));
128128

129-
opal_string_copy(intf->if_name, cur_ifaddrs->ifa_name, IF_NAMESIZE);
129+
opal_string_copy(intf->if_name, cur_ifaddrs->ifa_name, OPAL_IF_NAMESIZE);
130130
intf->if_index = opal_list_get_size(&opal_if_list) + 1;
131131
((struct sockaddr_in*) &intf->if_addr)->sin_addr = a4;
132132
((struct sockaddr_in*) &intf->if_addr)->sin_family = AF_INET;

opal/mca/if/bsdx_ipv6/if_bsdx_ipv6.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ static int if_bsdx_ipv6_open(void)
185185
return OPAL_ERR_OUT_OF_RESOURCE;
186186
}
187187
intf->af_family = AF_INET6;
188-
opal_string_copy(intf->if_name, cur_ifaddrs->ifa_name, IF_NAMESIZE);
188+
opal_string_copy(intf->if_name, cur_ifaddrs->ifa_name, OPAL_IF_NAMESIZE);
189189
intf->if_index = opal_list_get_size(&opal_if_list) + 1;
190190
((struct sockaddr_in6*) &intf->if_addr)->sin6_addr = a6;
191191
((struct sockaddr_in6*) &intf->if_addr)->sin6_family = AF_INET6;

opal/mca/if/if.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ BEGIN_C_DECLS
7474

7575
typedef struct opal_if_t {
7676
opal_list_item_t super;
77-
char if_name[IF_NAMESIZE];
77+
char if_name[OPAL_IF_NAMESIZE];
7878
int if_index;
7979
uint16_t if_kernel_index;
8080
uint16_t af_family;

opal/mca/if/linux_ipv6/if_linux_ipv6.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ static int if_linux_ipv6_open(void)
115115
#if OPAL_ENABLE_IPV6
116116
FILE *f;
117117
if ((f = fopen("/proc/net/if_inet6", "r"))) {
118-
char ifname[IF_NAMESIZE];
118+
char ifname[OPAL_IF_NAMESIZE];
119119
unsigned int idx, pfxlen, scope, dadstat;
120120
struct in6_addr a6;
121121
uint32_t flag;
@@ -158,7 +158,7 @@ static int if_linux_ipv6_open(void)
158158
intf->af_family = AF_INET6;
159159

160160
/* now construct the opal_if_t */
161-
opal_string_copy(intf->if_name, ifname, IF_NAMESIZE);
161+
opal_string_copy(intf->if_name, ifname, OPAL_IF_NAMESIZE);
162162
intf->if_index = opal_list_get_size(&opal_if_list)+1;
163163
intf->if_kernel_index = (uint16_t) idx;
164164
((struct sockaddr_in6*) &intf->if_addr)->sin6_addr = a6;

opal/mca/if/solaris_ipv6/if_solaris_ipv6.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ static int if_solaris_ipv6_open(void)
141141
}
142142
intf->af_family = AF_INET6;
143143

144-
opal_string_copy (intf->if_name, lifreq->lifr_name, IF_NAMESIZE);
144+
opal_string_copy (intf->if_name, lifreq->lifr_name, OPAL_IF_NAMESIZE);
145145
intf->if_index = opal_list_get_size(&opal_if_list)+1;
146146
memcpy(&intf->if_addr, my_addr, sizeof (*my_addr));
147147
intf->if_mask = 64;

opal/test/reachable/reachable_shared.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ BEGIN_C_DECLS
2424
opal_if_t* create_if(int af_family, char *address, int mask, int bandwidth)
2525
{
2626
opal_if_t *interface = OBJ_NEW(opal_if_t);
27-
opal_string_copy(interface->if_name, "interface0", IF_NAMESIZE);
27+
opal_string_copy(interface->if_name, "interface0", OPAL_IF_NAMESIZE);
2828
interface->af_family = af_family;
2929
((struct sockaddr *)&(interface->if_addr))->sa_family = af_family;
3030

0 commit comments

Comments
 (0)