Skip to content

Commit 8adbe9f

Browse files
author
Ralph Castain
authored
Merge pull request #4301 from rhc54/topic/fixes
Fix the embedded hwloc configure to always disable cuda support
2 parents fa01fad + c341b53 commit 8adbe9f

File tree

2 files changed

+8
-29
lines changed

2 files changed

+8
-29
lines changed

opal/mca/hwloc/external/external.h

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Copyright (c) 2016 Research Organization for Information Science
44
* and Technology (RIST). All rights reserved.
55
*
6-
* Copyright (c) 2016 Intel, Inc. All rights reserved.
6+
* Copyright (c) 2016-2017 Intel, Inc. All rights reserved.
77
* $COPYRIGHT$
88
*
99
* Additional copyrights may follow
@@ -43,6 +43,11 @@ BEGIN_C_DECLS
4343
# endif
4444
#endif
4545

46+
#if HWLOC_API_VERSION < 0x00010b00
47+
#define HWLOC_OBJ_NUMANODE HWLOC_OBJ_NODE
48+
#define HWLOC_OBJ_PACKAGE HWLOC_OBJ_SOCKET
49+
#endif
50+
4651
END_C_DECLS
4752

4853
#endif /* MCA_OPAL_HWLOC_EXTERNAL_H */

opal/mca/hwloc/hwloc2a/configure.m4

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -122,35 +122,9 @@ AC_DEFUN([MCA_opal_hwloc_hwloc2a_CONFIG],[
122122
enable_gl=no
123123
enable_opencl=no
124124

125-
# Per https://github.com/open-mpi/ompi/issues/4219, if
126-
# --without-cuda was specified, be sure to disable it in hwloc,
127-
# too. Note that hwloc uses --disable-cuda (i.e., a yes or no
128-
# value), whereas we use --with-cuda here in Open MPI (i.e., a
129-
# yes, no, or path value). Need to translate appropriately.
130-
#
131-
# Set enable_cuda to yes if:
132-
#
133-
# 1. --with-cuda was specified (i.e., a human specifically asked
134-
# for it)
135-
# 2. --with-cuda=blah was specified (i.e., a human specifically
136-
# asked for it)
137-
# 3. --with-cuda was not specified, but Open MPI is building CUDA
138-
# support
139-
#
140-
# Set enable_cuda to no in all other cases. This logic could be
141-
# compressed into a smaller set of if tests, but for readability /
142-
# clarity, I left it expanded.
143-
AC_MSG_CHECKING([for hwloc --enable-cuda value])
125+
# Per https://github.com/open-mpi/ompi/pull/4257, ALWAYS
126+
# disable cuda support
144127
enable_cuda=no
145-
AS_IF([test "$with_cuda" = "yes"],
146-
[enable_cuda=yes],
147-
[AS_IF([test -n "$with_cuda" && test "$with_cuda" != "no"],
148-
[enable_cuda=yes],
149-
[AS_IF([test "$opal_check_cuda_happy" = "yes"],
150-
[enable_cuda=yes])
151-
])
152-
])
153-
AC_MSG_RESULT(["$enable_cuda"])
154128

155129
# Open MPI currently does not use hwloc's NVML support
156130
enable_nvml=no

0 commit comments

Comments
 (0)