Skip to content

Commit 94ee228

Browse files
committed
ompi: resolve header dependency issues
This commit resolves issues discovered when sorting includes. This includes missing header files and one header dependency loop. There may be others but they are not exposed by an alphabetical include order. Signed-off-by: Nathan Hjelm <[email protected]>
1 parent edb0d97 commit 94ee228

File tree

9 files changed

+14
-3
lines changed

9 files changed

+14
-3
lines changed

ompi/datatype/ompi_datatype_internal.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#define OMPI_DATATYPE_INTERNAL_H
3030

3131
#include "opal/datatype/opal_datatype_internal.h"
32+
#include "ompi/datatype/ompi_datatype.h"
3233

3334
/*
3435
* This is the OMPI-layered numbering of ALL supported MPI types

ompi/mca/coll/adapt/coll_adapt_topocache.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
#ifndef MCA_COLL_ADAPT_TOPOCACHE_H
1414
#define MCA_COLL_ADAPT_TOPOCACHE_H
1515

16+
#include "ompi/communicator/communicator.h"
17+
#include "ompi/mca/coll/adapt/coll_adapt.h"
1618
#include "opal/class/opal_list.h"
1719
#include "ompi/mca/coll/coll.h"
1820
#include "ompi/mca/coll/base/coll_base_topo.h"

ompi/mca/coll/han/coll_han_dynamic.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
#include "ompi/mca/mca.h"
2222
#include "opal/util/output.h"
2323
#include "ompi/mca/coll/base/coll_base_functions.h"
24-
#include "ompi/mca/coll/han/coll_han.h"
25-
2624

2725
/*
2826
* @file

ompi/mca/common/monitoring/common_monitoring_coll.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ BEGIN_C_DECLS
1919

2020
#include "ompi_config.h"
2121
#include "opal/mca/base/mca_base_pvar.h"
22+
#include "ompi/mca/common/monitoring/common_monitoring.h"
2223

2324
OMPI_DECLSPEC void mca_common_monitoring_coll_flush(FILE *pf, mca_monitoring_coll_data_t*data);
2425

ompi/mca/osc/rdma/osc_rdma_sync.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
#if !defined(OSC_RDMA_SYNC_H)
1414
#define OSC_RDMA_SYNC_H
1515

16+
#include "ompi/group/group.h"
17+
#include "opal/mca/btl/btl.h"
1618
#include "osc_rdma_types.h"
1719
#include "opal/class/opal_object.h"
1820
#include "opal/mca/threads/threads.h"

ompi/mca/pml/ob1/pml_ob1_component.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
#ifndef MCA_PML_OB1_COMPONENT_H
2121
#define MCA_PML_OB1_COMPONENT_H
2222

23+
#include "ompi/mca/pml/pml.h"
24+
2325
BEGIN_C_DECLS
2426

2527
/*

ompi/mca/pml/ob1/pml_ob1_rdma.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@
2525
#ifndef MCA_PML_OB1_RDMA_H
2626
#define MCA_PML_OB1_RDMA_H
2727

28+
#include "ompi/mca/bml/bml.h"
29+
#include "ompi/mca/pml/ob1/pml_ob1_comm.h"
30+
2831
struct mca_bml_base_endpoint_t;
2932

3033
/*

ompi/mca/pml/ob1/pml_ob1_recvfrag.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
#ifndef MCA_PML_OB1_RECVFRAG_H
2929
#define MCA_PML_OB1_RECVFRAG_H
3030

31-
#include "pml_ob1_hdr.h"
31+
#include "ompi/mca/pml/ob1/pml_ob1_comm.h"
32+
#include "ompi/mca/pml/ob1/pml_ob1_hdr.h"
3233

3334
BEGIN_C_DECLS
3435

ompi/mca/vprotocol/pessimist/vprotocol_pessimist_eventlog.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#ifndef __VPROTOCOL_PESSIMIST_EVENTLOG_H__
1212
#define __VPROTOCOL_PESSIMIST_EVENTLOG_H__
1313

14+
#include "ompi/mca/pml/v/pml_v_output.h"
1415
#include "vprotocol_pessimist.h"
1516
#include "vprotocol_pessimist_request.h"
1617
#include "vprotocol_pessimist_eventlog_protocol.h"

0 commit comments

Comments
 (0)