Skip to content

Commit 971d58c

Browse files
committed
coll/han: remove references to experimental solo and shared collective components
Also make coll/tuned the default for shared memory communication as coll/sm has shown performance issues that need investigation. Signed-off-by: Joseph Schuchart <[email protected]>
1 parent 09c2f4a commit 971d58c

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

ompi/mca/coll/han/coll_han_component.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ ompi_coll_han_components available_components[COMPONENTS_COUNT] = {
3939
{ LIBNBC, "libnbc", NULL },
4040
{ TUNED, "tuned", NULL },
4141
{ SM, "sm", NULL },
42-
{ SHARED, "shared", NULL },
4342
{ ADAPT, "adapt", NULL },
4443
{ HAN, "han", NULL }
4544
};
@@ -179,7 +178,7 @@ static int han_register(void)
179178

180179
cs->han_bcast_low_module = 0;
181180
(void) mca_base_component_var_register(c, "bcast_low_module",
182-
"low level module for bcast, 0 sm, 1 solo",
181+
"low level module for bcast, 0 tuned, 1 sm",
183182
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
184183
OPAL_INFO_LVL_9,
185184
MCA_BASE_VAR_SCOPE_READONLY, &cs->han_bcast_low_module);
@@ -200,7 +199,7 @@ static int han_register(void)
200199

201200
cs->han_reduce_low_module = 0;
202201
(void) mca_base_component_var_register(c, "reduce_low_module",
203-
"low level module for allreduce, 0 sm, 1 shared",
202+
"low level module for allreduce, 0 tuned, 1 sm",
204203
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
205204
OPAL_INFO_LVL_9,
206205
MCA_BASE_VAR_SCOPE_READONLY, &cs->han_reduce_low_module);
@@ -220,7 +219,7 @@ static int han_register(void)
220219

221220
cs->han_allreduce_low_module = 0;
222221
(void) mca_base_component_var_register(c, "allreduce_low_module",
223-
"low level module for allreduce, 0 sm, 1 shared",
222+
"low level module for allreduce, 0 tuned, 1 sm",
224223
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
225224
OPAL_INFO_LVL_9,
226225
MCA_BASE_VAR_SCOPE_READONLY, &cs->han_allreduce_low_module);
@@ -234,7 +233,7 @@ static int han_register(void)
234233

235234
cs->han_allgather_low_module = 0;
236235
(void) mca_base_component_var_register(c, "allgather_low_module",
237-
"low level module for allgather, 0 sm, 1 shared",
236+
"low level module for allgather, 0 tuned, 1 sm",
238237
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
239238
OPAL_INFO_LVL_9,
240239
MCA_BASE_VAR_SCOPE_READONLY, &cs->han_allgather_low_module);
@@ -248,7 +247,7 @@ static int han_register(void)
248247

249248
cs->han_gather_low_module = 0;
250249
(void) mca_base_component_var_register(c, "gather_low_module",
251-
"low level module for gather, 0 sm, 1 shared",
250+
"low level module for gather, 0 tuned, 1 sm",
252251
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
253252
OPAL_INFO_LVL_9,
254253
MCA_BASE_VAR_SCOPE_READONLY, &cs->han_gather_low_module);
@@ -262,7 +261,7 @@ static int han_register(void)
262261

263262
cs->han_scatter_low_module = 0;
264263
(void) mca_base_component_var_register(c, "scatter_low_module",
265-
"low level module for scatter, 0 sm, 1 shared",
264+
"low level module for scatter, 0 tuned, 1 sm",
266265
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
267266
OPAL_INFO_LVL_9,
268267
MCA_BASE_VAR_SCOPE_READONLY, &cs->han_scatter_low_module);

ompi/mca/coll/han/coll_han_dynamic.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ typedef enum COMPONENTS {
102102
LIBNBC,
103103
TUNED,
104104
SM,
105-
SHARED,
106105
ADAPT,
107106
HAN,
108107
COMPONENTS_COUNT

ompi/mca/coll/han/coll_han_subcomms.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ int mca_coll_han_comm_create(struct ompi_communicator_t *comm,
258258
* Upgrade sm module priority to set up low_comms[0] with sm module
259259
* This sub-communicator contains the ranks that share my node.
260260
*/
261-
opal_info_set(&comm_info, "ompi_comm_coll_preference", "sm,^han");
261+
opal_info_set(&comm_info, "ompi_comm_coll_preference", "tuned,^han");
262262
ompi_comm_split_type(comm, MPI_COMM_TYPE_SHARED, 0,
263263
&comm_info, &(low_comms[0]));
264264

@@ -272,7 +272,7 @@ int mca_coll_han_comm_create(struct ompi_communicator_t *comm,
272272
* Upgrade shared module priority to set up low_comms[1] with shared module
273273
* This sub-communicator contains the ranks that share my node.
274274
*/
275-
opal_info_set(&comm_info, "ompi_comm_coll_preference", "shared,^han");
275+
opal_info_set(&comm_info, "ompi_comm_coll_preference", "sm,^han");
276276
ompi_comm_split_type(comm, MPI_COMM_TYPE_SHARED, 0,
277277
&comm_info, &(low_comms[1]));
278278

0 commit comments

Comments
 (0)