Silence Coverity warning

Ralph Castain · Ralph Castain · commit 9e8c7d6295a9 · 2017-01-15T07:51:37.000-08:00
Signed-off-by: Ralph Castain &lt;rhc@open-mpi.org&gt;
diff --git a/orte/mca/iof/base/iof_base_frame.c b/orte/mca/iof/base/iof_base_frame.c
@@ -238,11 +238,11 @@ static void orte_iof_base_sink_construct(orte_iof_sink_t* ptr)
 }
 static void orte_iof_base_sink_destruct(orte_iof_sink_t* ptr)
 {
-    OPAL_OUTPUT_VERBOSE((20, orte_iof_base_framework.framework_output,
-                         "%s iof: closing sink for process %s on fd %d",
-                         ORTE_NAME_PRINT(ORTE_PROC_MY_NAME),
-                         ORTE_NAME_PRINT(&ptr->name), ptr->wev->fd));
     if (NULL != ptr->wev && 0 <= ptr->wev->fd) {
+        OPAL_OUTPUT_VERBOSE((20, orte_iof_base_framework.framework_output,
+                             "%s iof: closing sink for process %s on fd %d",
+                             ORTE_NAME_PRINT(ORTE_PROC_MY_NAME),
+                             ORTE_NAME_PRINT(&ptr->name), ptr->wev->fd));
         OBJ_RELEASE(ptr->wev);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -238,11 +238,11 @@ static void orte_iof_base_sink_construct(orte_iof_sink_t* ptr)`
`238`	`238`	`}`
`239`	`239`	`static void orte_iof_base_sink_destruct(orte_iof_sink_t* ptr)`
`240`	`240`	`{`
`241`		`- OPAL_OUTPUT_VERBOSE((20, orte_iof_base_framework.framework_output,`
`242`		`- "%s iof: closing sink for process %s on fd %d",`
`243`		`- ORTE_NAME_PRINT(ORTE_PROC_MY_NAME),`
`244`		`- ORTE_NAME_PRINT(&ptr->name), ptr->wev->fd));`
`245`	`241`	`if (NULL != ptr->wev && 0 <= ptr->wev->fd) {`
	`242`	`+ OPAL_OUTPUT_VERBOSE((20, orte_iof_base_framework.framework_output,`
	`243`	`+ "%s iof: closing sink for process %s on fd %d",`
	`244`	`+ ORTE_NAME_PRINT(ORTE_PROC_MY_NAME),`
	`245`	`+ ORTE_NAME_PRINT(&ptr->name), ptr->wev->fd));`
`246`	`246`	`OBJ_RELEASE(ptr->wev);`
`247`	`247`	`}`
`248`	`248`	`}`