Skip to content

Commit a0acc73

Browse files
[OSC/UBCL] Window infos violation are not be fatal, just prints a warning and returns an error
Signed-off-by: Brelle Emmanuel <[email protected]>
1 parent 81adcc0 commit a0acc73

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

ompi/mca/osc/ubcl/osc_ubcl_sync.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,8 @@ int ompi_osc_ubcl_lock(int lock_type, int target, int assert, struct ompi_win_t
184184
mca_osc_ubcl_module_t *module = (mca_osc_ubcl_module_t *) win->w_osc_module;
185185

186186
if (module->no_locks) {
187-
mca_osc_ubcl_error(OMPI_ERR_RMA_SYNC, "MPI_Win_lock : window %d is no_locks=true", module->wid);
187+
mca_osc_ubcl_warn(OMPI_ERR_RMA_SYNC, "MPI_Win_lock : window %d is no_locks=true", module->wid);
188+
return OMPI_ERR_RMA_SYNC;
188189
}
189190

190191
OPAL_THREAD_LOCK(&module->sync_lock);
@@ -262,7 +263,8 @@ int ompi_osc_ubcl_unlock(int target, struct ompi_win_t *win)
262263
mca_osc_ubcl_module_t *module = (mca_osc_ubcl_module_t *) win->w_osc_module;
263264

264265
if (module->no_locks) {
265-
mca_osc_ubcl_error(OMPI_ERR_RMA_SYNC, "MPI_Win_unlock : window %d is no_locks=true", module->wid);
266+
mca_osc_ubcl_warn(OMPI_ERR_RMA_SYNC, "MPI_Win_unlock : window %d is no_locks=true", module->wid);
267+
return OMPI_ERR_RMA_SYNC;
266268
}
267269

268270
OPAL_THREAD_LOCK(&module->sync_lock);
@@ -354,7 +356,8 @@ int ompi_osc_ubcl_lock_all(int assert, struct ompi_win_t *win)
354356
mca_osc_ubcl_module_t *module = (mca_osc_ubcl_module_t *) win->w_osc_module;
355357

356358
if (module->no_locks) {
357-
mca_osc_ubcl_error(OMPI_ERR_RMA_SYNC, "MPI_Win_lockall : window %d is no_locks=true", module->wid);
359+
mca_osc_ubcl_warn(OMPI_ERR_RMA_SYNC, "MPI_Win_lockall : window %d is no_locks=true", module->wid);
360+
return OMPI_ERR_RMA_SYNC;
358361
}
359362

360363
/* check access epoch */
@@ -401,7 +404,8 @@ int ompi_osc_ubcl_unlock_all(struct ompi_win_t *win)
401404
mca_osc_ubcl_module_t *module = (mca_osc_ubcl_module_t *) win->w_osc_module;
402405

403406
if (module->no_locks) {
404-
mca_osc_ubcl_error(OMPI_ERR_RMA_SYNC, "MPI_Win_unlockall : window %d is no_locks=true", module->wid);
407+
mca_osc_ubcl_warn(OMPI_ERR_RMA_SYNC, "MPI_Win_unlockall : window %d is no_locks=true", module->wid);
408+
return OMPI_ERR_RMA_SYNC;
405409
}
406410

407411
if (UBCL_WIN_SYNC_LOCK_ALL_NO_CHECK == module->sync_type) {

0 commit comments

Comments
 (0)