Don't enqueue continuations twice for execution if everything is complete at registration

devreal · devreal · commit aa0a59d5b052 · 2021-11-08T18:57:27.000-05:00
Signed-off-by: Joseph Schuchart &lt;schuchart@icl.utk.edu&gt;
diff --git a/ompi/mpiext/continue/c/continuation.c b/ompi/mpiext/continue/c/continuation.c
@@ -556,10 +556,11 @@ int ompi_continue_attach(
         }
     }
 
+    assert(count >= num_registered);
     int num_complete = count - num_registered;
     int32_t last_num_active = OPAL_THREAD_ADD_FETCH32(&cont->num_active,
                                                       -num_complete);
-    if (0 == last_num_active && 0 < num_complete) {
+    if (0 == last_num_active && 0 == num_registered) {
         if (cont_req->cont_enqueue_complete) {
             /* enqueue for later processing */
             ompi_continue_enqueue_runnable(cont);

Original file line number	Diff line number	Diff line change
`@@ -556,10 +556,11 @@ int ompi_continue_attach(`
`556`	`556`	`}`
`557`	`557`	`}`
`558`	`558`
	`559`	`+ assert(count >= num_registered);`
`559`	`560`	`int num_complete = count - num_registered;`
`560`	`561`	`int32_t last_num_active = OPAL_THREAD_ADD_FETCH32(&cont->num_active,`
`561`	`562`	`-num_complete);`
`562`		`- if (0 == last_num_active && 0 < num_complete) {`
	`563`	`+ if (0 == last_num_active && 0 == num_registered) {`
`563`	`564`	`if (cont_req->cont_enqueue_complete) {`
`564`	`565`	`/* enqueue for later processing */`
`565`	`566`	`ompi_continue_enqueue_runnable(cont);`