pmix114/pmix1_client: fix misc memory leaks

ggouaillardet · ggouaillardet · commit b707d138fed4 · 2016-06-06T09:33:35.000+09:00
Fixes CID 1325146-1325149
diff --git a/opal/mca/pmix/pmix114/pmix1_client.c b/opal/mca/pmix/pmix114/pmix1_client.c
@@ -190,6 +190,7 @@ int pmix1_abort(int flag, const char *msg,
                 }
             }
             if (NULL == job) {
+                free(parray);
                 return OPAL_ERR_NOT_FOUND;
             }
             (void)strncpy(parray[n].nspace, job->nspace, PMIX_MAX_NSLEN);
@@ -291,6 +292,7 @@ int pmix1_fence(opal_list_t *procs, int collect_data)
                 }
             }
             if (NULL == job) {
+                free(parray);
                 return OPAL_ERR_NOT_FOUND;
             }
             (void)strncpy(parray[n].nspace, job->nspace, PMIX_MAX_NSLEN);
@@ -353,6 +355,7 @@ int pmix1_fencenb(opal_list_t *procs, int collect_data,
                 }
             }
             if (NULL == job) {
+                free(parray);
                 return OPAL_ERR_NOT_FOUND;
             }
             (void)strncpy(parray[n].nspace, job->nspace, PMIX_MAX_NSLEN);
@@ -1063,6 +1066,7 @@ int pmix1_connect(opal_list_t *procs)
             }
         }
         if (NULL == job) {
+            free(parray);
             OPAL_ERROR_LOG(OPAL_ERR_NOT_FOUND);
             return OPAL_ERR_NOT_FOUND;
         }

Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,7 @@ int pmix1_abort(int flag, const char *msg,`
`190`	`190`	`}`
`191`	`191`	`}`
`192`	`192`	`if (NULL == job) {`
	`193`	`+ free(parray);`
`193`	`194`	`return OPAL_ERR_NOT_FOUND;`
`194`	`195`	`}`
`195`	`196`	`(void)strncpy(parray[n].nspace, job->nspace, PMIX_MAX_NSLEN);`
`@@ -291,6 +292,7 @@ int pmix1_fence(opal_list_t *procs, int collect_data)`
`291`	`292`	`}`
`292`	`293`	`}`
`293`	`294`	`if (NULL == job) {`
	`295`	`+ free(parray);`
`294`	`296`	`return OPAL_ERR_NOT_FOUND;`
`295`	`297`	`}`
`296`	`298`	`(void)strncpy(parray[n].nspace, job->nspace, PMIX_MAX_NSLEN);`
`@@ -353,6 +355,7 @@ int pmix1_fencenb(opal_list_t *procs, int collect_data,`
`353`	`355`	`}`
`354`	`356`	`}`
`355`	`357`	`if (NULL == job) {`
	`358`	`+ free(parray);`
`356`	`359`	`return OPAL_ERR_NOT_FOUND;`
`357`	`360`	`}`
`358`	`361`	`(void)strncpy(parray[n].nspace, job->nspace, PMIX_MAX_NSLEN);`
`@@ -1063,6 +1066,7 @@ int pmix1_connect(opal_list_t *procs)`
`1063`	`1066`	`}`
`1064`	`1067`	`}`
`1065`	`1068`	`if (NULL == job) {`
	`1069`	`+ free(parray);`
`1066`	`1070`	`OPAL_ERROR_LOG(OPAL_ERR_NOT_FOUND);`
`1067`	`1071`	`return OPAL_ERR_NOT_FOUND;`
`1068`	`1072`	`}`