Skip to content

Commit bc2dce9

Browse files
committed
ompi: remove C++ bindings
The C++ bindings were removed from the MPI standard in MPI-3.0 back in 2012. This commit removes them but leaves the glue necessary to build mpicxx. Additional cleanup is probably needed. Signed-off-by: Nathan Hjelm <[email protected]>
1 parent 2cd8499 commit bc2dce9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+5
-8567
lines changed

Makefile.ompi-rules

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99
#
1010

1111
TRIM_OPTIONS=
12-
if ! MAN_PAGE_BUILD_MPI_CXX_BINDINGS
13-
TRIM_OPTIONS += --nocxx
14-
endif
1512
if ! MAN_PAGE_BUILD_MPIFH_BINDINGS
1613
TRIM_OPTIONS += --nofortran
1714
endif

config/ompi_setup_cxx.m4

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,6 @@ AC_DEFUN([OMPI_SETUP_CXX],[
5858
_OMPI_CXX_CHECK_BUILTIN
5959

6060
_OMPI_CXX_CHECK_2D_CONST_CAST
61-
62-
AM_CONDITIONAL(OMPI_BUILD_MPI_CXX_BINDINGS, [test "$WANT_MPI_CXX_SUPPORT" = 1])
63-
AC_DEFINE_UNQUOTED(OMPI_BUILD_CXX_BINDINGS, $WANT_MPI_CXX_SUPPORT,
64-
[Whether we want MPI C++ support or not])
6561
])
6662

6763
# _OMPI_SETUP_CXX_COMPILER()

config/opal_setup_cxx.m4

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -189,18 +189,6 @@ EOF
189189
AC_MSG_ERROR([C and C++ compilers are not link compatible. Can not continue.])])
190190
fi
191191

192-
# If we are on HP-UX, ensure that we're using aCC
193-
case "$host" in
194-
*hpux*)
195-
if test "$BASECXX" = "CC"; then
196-
AC_MSG_WARN([*** You will probably have problems compiling the MPI 2])
197-
AC_MSG_WARN([*** C++ bindings with the HP-UX CC compiler. You should])
198-
AC_MSG_WARN([*** probably be using the aCC compiler. Re-run configure])
199-
AC_MSG_WARN([*** with the environment variable "CXX=aCC".])
200-
fi
201-
;;
202-
esac
203-
204192
# Note: gcc-imperonating compilers accept -O3
205193
if test "$WANT_DEBUG" = "1"; then
206194
OPTFLAGS=

configure.ac

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -534,9 +534,6 @@ OPAL_CHECK_OFFSETOF
534534
# OPAL...? Shrug.
535535
m4_ifdef([project_ompi], [OPAL_SETUP_CXX
536536
OMPI_SETUP_CXX])
537-
# Used in Makefile.ompi-rules
538-
AM_CONDITIONAL(MAN_PAGE_BUILD_MPI_CXX_BINDINGS,
539-
[test "$WANT_MPI_CXX_SUPPORT" = 1])
540537

541538
##################################
542539
# Only after setting up both

ompi/Makefile.am

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ SUBDIRS = \
8585
$(MCA_ompi_FRAMEWORKS_SUBDIRS) \
8686
$(MCA_ompi_FRAMEWORK_COMPONENT_STATIC_SUBDIRS) \
8787
. \
88-
mpi/cxx \
8988
$(OMPI_MPIEXT_MPIFH_DIRS) \
9089
mpi/fortran/mpif-h \
9190
$(OMPI_MPIEXT_USEMPI_DIR) \
@@ -114,7 +113,6 @@ DIST_SUBDIRS = \
114113
etc \
115114
mpi/c \
116115
mpi/tool \
117-
mpi/cxx \
118116
mpi/fortran/base \
119117
mpi/fortran/mpif-h \
120118
mpi/fortran/use-mpi-tkr \

ompi/include/mpi.h.in

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -160,15 +160,6 @@
160160
/* type to use for ptrdiff_t, if it does not exist, set to ptrdiff_t if it does exist */
161161
#undef ptrdiff_t
162162

163-
/* Whether we want MPI cxx support or not */
164-
#undef OMPI_BUILD_CXX_BINDINGS
165-
166-
/* do we want to try to work around C++ bindings SEEK_* issue? */
167-
#undef OMPI_WANT_MPI_CXX_SEEK
168-
169-
/* Whether a const_cast on a 2-d array will work with the C++ compiler */
170-
#undef OMPI_CXX_SUPPORTS_2D_CONST_CAST
171-
172163
/* Whether OMPI was built with parameter checking or not */
173164
#undef OMPI_PARAM_CHECK
174165

@@ -177,9 +168,6 @@
177168
#undef OMPI_WANT_MPI_INTERFACE_WARNING
178169
#endif
179170

180-
/* Whether or not we have compiled with C++ exceptions support */
181-
#undef OMPI_HAVE_CXX_EXCEPTION_SUPPORT
182-
183171
/* Major, minor, and release version of Open MPI */
184172
#undef OMPI_MAJOR_VERSION
185173
#undef OMPI_MINOR_VERSION
@@ -247,10 +235,7 @@
247235
* only relevant if we're not building Open MPI (i.e., we're compiling an
248236
* MPI application).
249237
*/
250-
#if !(OMPI_BUILDING || \
251-
(defined(OMPI_BUILDING_CXX_BINDINGS_LIBRARY) && \
252-
OMPI_BUILDING_CXX_BINDINGS_LIBRARY))
253-
238+
#if !OMPI_BUILDING
254239
/*
255240
* Figure out which compiler is being invoked (in order to compare if
256241
* it was different than what OMPI was built with).
@@ -2568,18 +2553,4 @@ OMPI_DECLSPEC int MPI_T_enum_get_item(MPI_T_enum enumtype, int index, int *valu
25682553
}
25692554
#endif
25702555

2571-
/*
2572-
* Conditional MPI 2 C++ bindings support. Include if:
2573-
* - The user does not explicitly request us to skip it (when a C++ compiler
2574-
* is used to compile C code).
2575-
* - We want C++ bindings support
2576-
* - We are not building OMPI itself
2577-
* - We are using a C++ compiler
2578-
*/
2579-
#if !defined(OMPI_SKIP_MPICXX) && OMPI_BUILD_CXX_BINDINGS && !OMPI_BUILDING
2580-
#if defined(c_plusplus) || defined(__cplusplus)
2581-
#include "openmpi/ompi/mpi/cxx/mpicxx.h"
2582-
#endif
2583-
#endif
2584-
25852556
#endif /* OMPI_MPI_H */

ompi/mpi/cxx/Makefile.am

Lines changed: 0 additions & 85 deletions
This file was deleted.

ompi/mpi/cxx/comm.cc

Lines changed: 0 additions & 135 deletions
This file was deleted.

0 commit comments

Comments
 (0)