orte: plug a memory leak in orte_rml.recv_cancel

do not invoke orte_rml.recv_cancel after the orte progress thread has gone

Signed-off-by: Gilles Gouaillardet <[email protected]>

Author: ggouaillardet

orte/mca/filem/raw/filem_raw_module.c

@@ -3,7 +3,7 @@
  *                         All rights reserved
  * Copyright (c) 2013      Cisco Systems, Inc.  All rights reserved.
  * Copyright (c) 2014-2016 Intel, Inc.  All rights reserved.
- * Copyright (c) 2015      Research Organization for Information Science
+ * Copyright (c) 2015-2017 Research Organization for Information Science
  *                         and Technology (RIST). All rights reserved.
  * $COPYRIGHT$
  *
@@ -145,7 +145,6 @@ static int raw_finalize(void)
 {
     opal_list_item_t *item;
 
-    orte_rml.recv_cancel(ORTE_NAME_WILDCARD, ORTE_RML_TAG_FILEM_BASE);
     while (NULL != (item = opal_list_remove_first(&incoming_files))) {
         OBJ_RELEASE(item);
     }
@@ -160,7 +159,6 @@ static int raw_finalize(void)
             OBJ_RELEASE(item);
         }
         OBJ_DESTRUCT(&positioned_files);
-        orte_rml.recv_cancel(ORTE_NAME_WILDCARD, ORTE_RML_TAG_FILEM_BASE_RESP);
     }
 
     return ORTE_SUCCESS;

orte/mca/grpcomm/direct/grpcomm_direct.c

@@ -6,7 +6,7 @@
  * Copyright (c) 2011-2013 Los Alamos National Security, LLC. All
  *                         rights reserved.
  * Copyright (c) 2014-2016 Intel, Inc.  All rights reserved.
- * Copyright (c) 2014      Research Organization for Information Science
+ * Copyright (c) 2014-2017 Research Organization for Information Science
  *                         and Technology (RIST). All rights reserved.
  * $COPYRIGHT$
  *
@@ -98,9 +98,6 @@ static int init(void)
  */
 static void finalize(void)
 {
-    /* cancel the recv */
-    orte_rml.recv_cancel(ORTE_NAME_WILDCARD, ORTE_RML_TAG_XCAST);
-
     OPAL_LIST_DESTRUCT(&tracker);
     return;
 }

orte/mca/iof/hnp/iof_hnp.c

@@ -13,7 +13,7 @@
  * Copyright (c) 2007      Cisco Systems, Inc.  All rights reserved.
  * Copyright (c) 2011-2013 Los Alamos National Security, LLC.  All rights
  *                         reserved.
- * Copyright (c) 2014      Research Organization for Information Science
+ * Copyright (c) 2014-2017 Research Organization for Information Science
  *                         and Technology (RIST). All rights reserved.
  * Copyright (c) 2016-2017 Intel, Inc. All rights reserved.
  * $COPYRIGHT$
@@ -480,7 +480,6 @@ static int finalize(void)
         OBJ_RELEASE(proct);
     }
     OBJ_DESTRUCT(&mca_iof_hnp_component.procs);
-    orte_rml.recv_cancel(ORTE_NAME_WILDCARD, ORTE_RML_TAG_IOF_HNP);
 
     return ORTE_SUCCESS;
 }

orte/mca/plm/base/plm_base_receive.c

@@ -13,6 +13,8 @@
  * Copyright (c) 2011      Los Alamos National Security, LLC.
  *                         All rights reserved.
  * Copyright (c) 2014-2016 Intel, Inc.  All rights reserved.
+ * Copyright (c) 2017      Research Organization for Information Science
+ *                         and Technology (RIST). All rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -101,10 +103,6 @@ int orte_plm_base_comm_stop(void)
                          "%s plm:base:receive stop comm",
                          ORTE_NAME_PRINT(ORTE_PROC_MY_NAME)));
 
-    orte_rml.recv_cancel(ORTE_NAME_WILDCARD, ORTE_RML_TAG_PLM);
-    if (ORTE_PROC_IS_HNP) {
-        orte_rml.recv_cancel(ORTE_NAME_WILDCARD, ORTE_RML_TAG_ORTED_CALLBACK);
-    }
     recv_issued = false;
 
     return ORTE_SUCCESS;

orte/orted/orted_submit.c

@@ -590,8 +590,6 @@ void orte_submit_finalize(void)
     trackr_t *trk;
     int i;
 
-    orte_rml.recv_cancel(ORTE_NAME_WILDCARD, ORTE_RML_TAG_LAUNCH_RESP);
-    orte_rml.recv_cancel(ORTE_NAME_WILDCARD, ORTE_RML_TAG_NOTIFY_COMPLETE);
     for (i=0; i < tool_jobs.size; i++) {
         if (NULL != (trk = (trackr_t*)opal_pointer_array_get_item(&tool_jobs, i))) {
             OBJ_RELEASE(trk);

orte/runtime/orte_data_server.c

@@ -13,6 +13,8 @@
  * Copyright (c) 2012-2016 Los Alamos National Security, LLC.
  *                         All rights reserved
  * Copyright (c) 2015-2016 Intel, Inc.  All rights reserved.
+ * Copyright (c) 2017      Research Organization for Information Science
+ *                         and Technology (RIST). All rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -149,8 +151,6 @@ void orte_data_server_finalize(void)
     }
     initialized = false;
 
-    orte_rml.recv_cancel(ORTE_NAME_WILDCARD, ORTE_RML_TAG_DATA_SERVER);
-
     for (i=0; i < orte_data_server_store.size; i++) {
         if (NULL != (data = (orte_data_object_t*)opal_pointer_array_get_item(&orte_data_server_store, i))) {
             OBJ_RELEASE(data);