Skip to content

Commit c81795c

Browse files
committed
Revert "Fix MPI_SIZEOF for gfortran 4.8"
This reverts commit 5de3d5d. Signed-off-by: Joshua Hursey <[email protected]>
1 parent 23ee602 commit c81795c

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

README

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ Copyright (c) 2013-2015 Intel, Inc. All rights reserved
1919
Copyright (c) 2015 NVIDIA Corporation. All rights reserved.
2020
Copyright (c) 2017 Los Alamos National Security, LLC. All rights
2121
reserved.
22-
Copyright (c) 2017 IBM Corporation. All rights reserved
2322

2423
$COPYRIGHT$
2524

@@ -371,7 +370,8 @@ Compiler Notes
371370
- All Fortran compilers support the mpif.h/shmem.fh-based bindings,
372371
with one exception: the MPI_SIZEOF interfaces will only be present
373372
when Open MPI is built with a Fortran compiler that support the
374-
INTERFACE keyword and ISO_FORTRAN_ENV.
373+
INTERFACE keyword and ISO_FORTRAN_ENV. Most notably, this
374+
excludes the GNU Fortran compiler suite before version 4.9.
375375

376376
- The level of support provided by the mpi module is based on your
377377
Fortran compiler.

config/ompi_fortran_check_storage_size.m4

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ dnl University of Stuttgart. All rights reserved.
1111
dnl Copyright (c) 2004-2005 The Regents of the University of California.
1212
dnl All rights reserved.
1313
dnl Copyright (c) 2010-2014 Cisco Systems, Inc. All rights reserved.
14-
dnl Copyright (c) 2017 IBM Corporation. All rights reserved.
1514
dnl $COPYRIGHT$
1615
dnl
1716
dnl Additional copyrights may follow
@@ -62,7 +61,7 @@ SUBROUTINE storage_size_complex32_r1(x, size)
6261
COMPLEX(REAL32), DIMENSION(*)::x
6362
INTEGER, INTENT(OUT) :: size
6463

65-
size = storage_size(x(1)) / 8
64+
size = storage_size(x) / 8
6665
END SUBROUTINE storage_size_complex32_r1
6766

6867
SUBROUTINE storage_size_int32_scalar(x, size)
@@ -78,7 +77,7 @@ SUBROUTINE storage_size_int32_r1(x, size)
7877
INTEGER(INT32), DIMENSION(*)::x
7978
INTEGER, INTENT(OUT) :: size
8079

81-
size = storage_size(x(1)) / 8
80+
size = storage_size(x) / 8
8281
END SUBROUTINE storage_size_int32_r1
8382

8483
SUBROUTINE storage_size_real32_scalar(x, size)
@@ -94,7 +93,7 @@ SUBROUTINE storage_size_real32_r1(x, size)
9493
REAL(REAL32), DIMENSION(*)::x
9594
INTEGER, INTENT(OUT) :: size
9695

97-
size = storage_size(x(1)) / 8
96+
size = storage_size(x) / 8
9897
END SUBROUTINE storage_size_real32_r1
9998
]])],
10099
[AS_VAR_SET(fortran_storage_size_var, yes)],

ompi/mpi/fortran/base/gen-mpi-sizeof.pl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
# Copyright (c) 2014-2015 Cisco Systems, Inc. All rights reserved.
44
# Copyright (c) 2015 Research Organization for Information Science
55
# and Technology (RIST). All rights reserved.
6-
# Copyright (c) 2017 IBM Corporation. All rights reserved.
76
# $COPYRIGHT$
87
#
98
# Script to generate the overloaded MPI_SIZEOF interfaces and
@@ -98,7 +97,7 @@ sub queue_sub {
9897
${indent} INTEGER, INTENT(OUT) :: size
9998
${indent} INTEGER$optional_ierror_param, INTENT(OUT) :: ierror";
10099
$subr->{start} = $start;
101-
$subr->{middle} = "${indent} size = storage_size(xSUBSCRIPT) / 8
100+
$subr->{middle} = "${indent} size = storage_size(x) / 8
102101
${indent} ${optional_ierror_statement}ierror = 0";
103102
$subr->{end} = "${indent}END SUBROUTINE ^PREFIX^$sub_name^RANK^";
104103

@@ -127,7 +126,6 @@ sub generate {
127126
if (0 == $rank) {
128127
$str =~ s/\^RANK\^/_scalar/g;
129128
$str =~ s/\^DIMENSION\^//;
130-
$str =~ s/SUBSCRIPT//;
131129
} else {
132130
$str =~ s/\^RANK\^/_r$rank/g;
133131
my $dim;
@@ -137,7 +135,6 @@ sub generate {
137135
--$d;
138136
}
139137
$str =~ s/\^DIMENSION\^/, DIMENSION($dim*)/;
140-
$str =~ s/SUBSCRIPT/($dim 1)/;
141138
}
142139

143140
# All done

0 commit comments

Comments
 (0)