ompio: correctly fix a memory plug

ggouaillardet · ggouaillardet · commit d1e1ec51b65f · 2016-09-08T18:50:18.000+09:00
as newly reported by Coverity with CID 1372660
diff --git a/ompi/mca/io/ompio/io_ompio_aggregators.c b/ompi/mca/io/ompio/io_ompio_aggregators.c
@@ -881,12 +881,13 @@ int mca_io_ompio_merge_groups(mca_io_ompio_file_t *fh,
 {
     int i = 0;
     int *sizes_old_group;
-    int ret = OMPI_SUCCESS;
-    int *displs;
+    int ret;
+    int *displs = NULL;
 
     sizes_old_group = (int*)malloc(num_merge_aggrs * sizeof(int));
     if (NULL == sizes_old_group) {
         opal_output (1, "OUT OF MEMORY\n");
+        ret = OMPI_ERR_OUT_OF_RESOURCE;
         goto exit;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -881,12 +881,13 @@ int mca_io_ompio_merge_groups(mca_io_ompio_file_t *fh,`
`881`	`881`	`{`
`882`	`882`	`int i = 0;`
`883`	`883`	`int *sizes_old_group;`
`884`		`- int ret = OMPI_SUCCESS;`
`885`		`- int *displs;`
	`884`	`+ int ret;`
	`885`	`+ int *displs = NULL;`
`886`	`886`
`887`	`887`	`sizes_old_group = (int)malloc(num_merge_aggrs sizeof(int));`
`888`	`888`	`if (NULL == sizes_old_group) {`
`889`	`889`	`opal_output (1, "OUT OF MEMORY\n");`
	`890`	`+ ret = OMPI_ERR_OUT_OF_RESOURCE;`
`890`	`891`	`goto exit;`
`891`	`892`	`}`
`892`	`893`