Skip to content

Commit d5200ea

Browse files
bwbarrettbwbarrett
authored
Merge pull request #3568 from ggouaillardet/topic/v3.x/opal_datatype_revamp
v3.x: revamp opal/datatype internals
2 parents 0c8f730 + 2eb4d53 commit d5200ea

File tree

80 files changed

+863
-626
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

80 files changed

+863
-626
lines changed

‎config/ompi_find_mpi_aint_count_offset.m4‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# Copyright (c) 2006-2007 Los Alamos National Security, LLC. All rights
1616
# reserved.
1717
# Copyright (c) 2009 Oak Ridge National Labs. All rights reserved.
18-
# Copyright (c) 2014 Research Organization for Information Science
18+
# Copyright (c) 2014-2017 Research Organization for Information Science
1919
# and Technology (RIST). All rights reserved.
2020
# Copyright (c) 2015 Intel, Inc. All rights reserved.
2121
# $COPYRIGHT$
@@ -42,14 +42,13 @@ AC_DEFUN([OMPI_FIND_MPI_AINT_COUNT_OFFSET],[
4242
dnl #########################################################################
4343

4444
AC_DEFUN([_OMPI_FIND_MPI_AINT_TYPE], [
45-
# Find the type of MPI_Aint. We already did the work to figure
46-
# out what opal_ptrdiff will be; just use that.
45+
# MPI_Aint type is ptrdiff_t; just use that.
4746
AC_MSG_CHECKING([for type of MPI_Aint])
4847

49-
MPI_AINT_TYPE=$opal_ptrdiff_t
48+
MPI_AINT_TYPE=ptrdiff_t
5049
# Get the size of this type; we'll need it to figure out Fortran's
5150
# MPI_ADDRESS_KIND, later
52-
MPI_AINT_SIZE=$opal_ptrdiff_size
51+
MPI_AINT_SIZE=$ac_cv_sizeof_ptrdiff_t
5352
AC_DEFINE_UNQUOTED(OMPI_MPI_AINT_TYPE, [$MPI_AINT_TYPE],
5453
[Type of MPI_Aint])
5554

‎configure.ac‎

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
# Copyright (c) 2013 Mellanox Technologies, Inc.
2121
# All rights reserved.
2222
# Copyright (c) 2013-2017 Intel, Inc. All rights reserved.
23-
# Copyright (c) 2014-2016 Research Organization for Information Science
23+
# Copyright (c) 2014-2017 Research Organization for Information Science
2424
# and Technology (RIST). All rights reserved.
2525
# Copyright (c) 2016 IBM Corporation. All rights reserved.
2626
# $COPYRIGHT$
@@ -420,6 +420,8 @@ if test "$ac_cv_type_ssize_t" = yes ; then
420420
fi
421421
if test "$ac_cv_type_ptrdiff_t" = yes; then
422422
AC_CHECK_SIZEOF(ptrdiff_t)
423+
else
424+
AC_MSG_ERROR([ptrdiff_t type is not available, this is required by C99 standard. Cannot continue])
423425
fi
424426
AC_CHECK_SIZEOF(wchar_t)
425427

@@ -782,27 +784,6 @@ AC_INCLUDES_DEFAULT
782784
#endif
783785
])
784786

785-
#
786-
# Check for ptrdiff type. Yes, there are platforms where
787-
# sizeof(void*) != sizeof(long) (64 bit Windows, apparently).
788-
#
789-
AC_MSG_CHECKING([for pointer diff type])
790-
if test $ac_cv_type_ptrdiff_t = yes ; then
791-
opal_ptrdiff_t="ptrdiff_t"
792-
opal_ptrdiff_size=$ac_cv_sizeof_ptrdiff_t
793-
elif test $ac_cv_sizeof_void_p -eq $ac_cv_sizeof_long ; then
794-
opal_ptrdiff_t="long"
795-
opal_ptrdiff_size=$ac_cv_sizeof_long
796-
elif test $ac_cv_type_long_long = yes && test $ac_cv_sizeof_void_p -eq $ac_cv_sizeof_long_long ; then
797-
opal_ptrdiff_t="long long"
798-
opal_ptrdiff_size=$ac_cv_sizeof_long_long
799-
else
800-
AC_MSG_ERROR([Could not find datatype to emulate ptrdiff_t. Cannot continue])
801-
fi
802-
AC_DEFINE_UNQUOTED([OPAL_PTRDIFF_TYPE], [$opal_ptrdiff_t],
803-
[type to use for ptrdiff_t])
804-
AC_MSG_RESULT([$opal_ptrdiff_t (size: $opal_ptrdiff_size)])
805-
806787
#
807788
# Find corresponding types for MPI_Aint, MPI_Count, and MPI_Offset.
808789
# And if relevant, find the corresponding MPI_ADDRESS_KIND,

‎ompi/datatype/ompi_datatype.h‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Copyright (c) 2010 Cisco Systems, Inc. All rights reserved.
88
* Copyright (c) 2013 Los Alamos National Security, LLC. All rights
99
* reserved.
10-
* Copyright (c) 2015-2016 Research Organization for Information Science
10+
* Copyright (c) 2015-2017 Research Organization for Information Science
1111
* and Technology (RIST). All rights reserved.
1212
* $COPYRIGHT$
1313
*
@@ -167,7 +167,7 @@ OMPI_DECLSPEC int32_t ompi_datatype_destroy( ompi_datatype_t** type);
167167
*/
168168
static inline int32_t
169169
ompi_datatype_add( ompi_datatype_t* pdtBase, const ompi_datatype_t* pdtAdd, uint32_t count,
170-
OPAL_PTRDIFF_TYPE disp, OPAL_PTRDIFF_TYPE extent )
170+
ptrdiff_t disp, ptrdiff_t extent )
171171
{
172172
return opal_datatype_add( &pdtBase->super, &pdtAdd->super, count, disp, extent );
173173
}
@@ -178,17 +178,17 @@ ompi_datatype_duplicate( const ompi_datatype_t* oldType, ompi_datatype_t** newTy
178178
OMPI_DECLSPEC int32_t ompi_datatype_create_contiguous( int count, const ompi_datatype_t* oldType, ompi_datatype_t** newType );
179179
OMPI_DECLSPEC int32_t ompi_datatype_create_vector( int count, int bLength, int stride,
180180
const ompi_datatype_t* oldType, ompi_datatype_t** newType );
181-
OMPI_DECLSPEC int32_t ompi_datatype_create_hvector( int count, int bLength, OPAL_PTRDIFF_TYPE stride,
181+
OMPI_DECLSPEC int32_t ompi_datatype_create_hvector( int count, int bLength, ptrdiff_t stride,
182182
const ompi_datatype_t* oldType, ompi_datatype_t** newType );
183183
OMPI_DECLSPEC int32_t ompi_datatype_create_indexed( int count, const int* pBlockLength, const int* pDisp,
184184
const ompi_datatype_t* oldType, ompi_datatype_t** newType );
185-
OMPI_DECLSPEC int32_t ompi_datatype_create_hindexed( int count, const int* pBlockLength, const OPAL_PTRDIFF_TYPE* pDisp,
185+
OMPI_DECLSPEC int32_t ompi_datatype_create_hindexed( int count, const int* pBlockLength, const ptrdiff_t* pDisp,
186186
const ompi_datatype_t* oldType, ompi_datatype_t** newType );
187187
OMPI_DECLSPEC int32_t ompi_datatype_create_indexed_block( int count, int bLength, const int* pDisp,
188188
const ompi_datatype_t* oldType, ompi_datatype_t** newType );
189-
OMPI_DECLSPEC int32_t ompi_datatype_create_hindexed_block( int count, int bLength, const OPAL_PTRDIFF_TYPE* pDisp,
189+
OMPI_DECLSPEC int32_t ompi_datatype_create_hindexed_block( int count, int bLength, const ptrdiff_t* pDisp,
190190
const ompi_datatype_t* oldType, ompi_datatype_t** newType );
191-
OMPI_DECLSPEC int32_t ompi_datatype_create_struct( int count, const int* pBlockLength, const OPAL_PTRDIFF_TYPE* pDisp,
191+
OMPI_DECLSPEC int32_t ompi_datatype_create_struct( int count, const int* pBlockLength, const ptrdiff_t* pDisp,
192192
ompi_datatype_t* const* pTypes, ompi_datatype_t** newType );
193193
OMPI_DECLSPEC int32_t ompi_datatype_create_darray( int size, int rank, int ndims, int const* gsize_array,
194194
int const* distrib_array, int const* darg_array,
@@ -199,8 +199,8 @@ OMPI_DECLSPEC int32_t ompi_datatype_create_subarray(int ndims, int const* size_a
199199
const ompi_datatype_t* oldtype, ompi_datatype_t** newtype);
200200
static inline int32_t
201201
ompi_datatype_create_resized( const ompi_datatype_t* oldType,
202-
OPAL_PTRDIFF_TYPE lb,
203-
OPAL_PTRDIFF_TYPE extent,
202+
ptrdiff_t lb,
203+
ptrdiff_t extent,
204204
ompi_datatype_t** newType )
205205
{
206206
ompi_datatype_t * type;
@@ -214,13 +214,13 @@ ompi_datatype_create_resized( const ompi_datatype_t* oldType,
214214
}
215215

216216
static inline int32_t
217-
ompi_datatype_type_lb( const ompi_datatype_t* type, OPAL_PTRDIFF_TYPE* disp )
217+
ompi_datatype_type_lb( const ompi_datatype_t* type, ptrdiff_t* disp )
218218
{
219219
return opal_datatype_type_lb(&type->super, disp);
220220
}
221221

222222
static inline int32_t
223-
ompi_datatype_type_ub( const ompi_datatype_t* type, OPAL_PTRDIFF_TYPE* disp )
223+
ompi_datatype_type_ub( const ompi_datatype_t* type, ptrdiff_t* disp )
224224
{
225225
return opal_datatype_type_ub( &type->super, disp);
226226
}
@@ -232,19 +232,19 @@ ompi_datatype_type_size ( const ompi_datatype_t* type, size_t *size )
232232
}
233233

234234
static inline int32_t
235-
ompi_datatype_type_extent( const ompi_datatype_t* type, OPAL_PTRDIFF_TYPE* extent )
235+
ompi_datatype_type_extent( const ompi_datatype_t* type, ptrdiff_t* extent )
236236
{
237237
return opal_datatype_type_extent( &type->super, extent);
238238
}
239239

240240
static inline int32_t
241-
ompi_datatype_get_extent( const ompi_datatype_t* type, OPAL_PTRDIFF_TYPE* lb, OPAL_PTRDIFF_TYPE* extent)
241+
ompi_datatype_get_extent( const ompi_datatype_t* type, ptrdiff_t* lb, ptrdiff_t* extent)
242242
{
243243
return opal_datatype_get_extent( &type->super, lb, extent);
244244
}
245245

246246
static inline int32_t
247-
ompi_datatype_get_true_extent( const ompi_datatype_t* type, OPAL_PTRDIFF_TYPE* true_lb, OPAL_PTRDIFF_TYPE* true_extent)
247+
ompi_datatype_get_true_extent( const ompi_datatype_t* type, ptrdiff_t* true_lb, ptrdiff_t* true_extent)
248248
{
249249
return opal_datatype_get_true_extent( &type->super, true_lb, true_extent);
250250
}
@@ -266,7 +266,7 @@ ompi_datatype_copy_content_same_ddt( const ompi_datatype_t* type, size_t count,
266266
char* pDestBuf, char* pSrcBuf )
267267
{
268268
int32_t length, rc;
269-
OPAL_PTRDIFF_TYPE extent;
269+
ptrdiff_t extent;
270270

271271
ompi_datatype_type_extent( type, &extent );
272272
while( 0 != count ) {
@@ -295,11 +295,11 @@ OMPI_DECLSPEC int32_t ompi_datatype_sndrcv( const void *sbuf, int32_t scount, co
295295
*/
296296
OMPI_DECLSPEC int32_t ompi_datatype_get_args( const ompi_datatype_t* pData, int32_t which,
297297
int32_t * ci, int32_t * i,
298-
int32_t * ca, OPAL_PTRDIFF_TYPE* a,
298+
int32_t * ca, ptrdiff_t* a,
299299
int32_t * cd, ompi_datatype_t** d, int32_t * type);
300300
OMPI_DECLSPEC int32_t ompi_datatype_set_args( ompi_datatype_t* pData,
301301
int32_t ci, const int32_t ** i,
302-
int32_t ca, const OPAL_PTRDIFF_TYPE* a,
302+
int32_t ca, const ptrdiff_t* a,
303303
int32_t cd, ompi_datatype_t* const * d,int32_t type);
304304
OMPI_DECLSPEC int32_t ompi_datatype_copy_args( const ompi_datatype_t* source_data,
305305
ompi_datatype_t* dest_data );

‎ompi/datatype/ompi_datatype_args.c‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* Copyright (c) 2009 Oak Ridge National Labs. All rights reserved.
1414
* Copyright (c) 2013-2016 Los Alamos National Security, LLC. All rights
1515
* reserved.
16-
* Copyright (c) 2015-2016 Research Organization for Information Science
16+
* Copyright (c) 2015-2017 Research Organization for Information Science
1717
* and Technology (RIST). All rights reserved.
1818
* $COPYRIGHT$
1919
*
@@ -40,7 +40,7 @@ static inline int
4040
__ompi_datatype_pack_description( ompi_datatype_t* datatype,
4141
void** packed_buffer, int* next_index );
4242
static ompi_datatype_t*
43-
__ompi_datatype_create_from_args( int32_t* i, OPAL_PTRDIFF_TYPE * a,
43+
__ompi_datatype_create_from_args( int32_t* i, ptrdiff_t * a,
4444
ompi_datatype_t** d, int32_t type );
4545

4646
typedef struct __dt_args {
@@ -51,7 +51,7 @@ typedef struct __dt_args {
5151
int32_t ca;
5252
int32_t cd;
5353
int* i;
54-
OPAL_PTRDIFF_TYPE* a;
54+
ptrdiff_t* a;
5555
ompi_datatype_t** d;
5656
} ompi_datatype_args_t;
5757

@@ -65,7 +65,7 @@ typedef struct __dt_args {
6565
*/
6666
#if OPAL_ALIGN_WORD_SIZE_INTEGERS
6767
#define OMPI_DATATYPE_ALIGN_PTR(PTR, TYPE) \
68-
(PTR) = OPAL_ALIGN_PTR((PTR), sizeof(OPAL_PTRDIFF_TYPE), TYPE)
68+
(PTR) = OPAL_ALIGN_PTR((PTR), sizeof(ptrdiff_t), TYPE)
6969
#else
7070
#define OMPI_DATATYPE_ALIGN_PTR(PTR, TYPE)
7171
#endif /* OPAL_ALIGN_WORD_SIZE_INTEGERS */
@@ -80,7 +80,7 @@ typedef struct __dt_args {
8080
#define ALLOC_ARGS(PDATA, IC, AC, DC) \
8181
do { \
8282
int length = sizeof(ompi_datatype_args_t) + (IC) * sizeof(int) + \
83-
(AC) * sizeof(OPAL_PTRDIFF_TYPE) + (DC) * sizeof(MPI_Datatype); \
83+
(AC) * sizeof(ptrdiff_t) + (DC) * sizeof(MPI_Datatype); \
8484
char* buf = (char*)malloc( length ); \
8585
ompi_datatype_args_t* pArgs = (ompi_datatype_args_t*)buf; \
8686
pArgs->ci = (IC); \
@@ -89,8 +89,8 @@ typedef struct __dt_args {
8989
buf += sizeof(ompi_datatype_args_t); \
9090
if( pArgs->ca == 0 ) pArgs->a = NULL; \
9191
else { \
92-
pArgs->a = (OPAL_PTRDIFF_TYPE*)buf; \
93-
buf += pArgs->ca * sizeof(OPAL_PTRDIFF_TYPE); \
92+
pArgs->a = (ptrdiff_t*)buf; \
93+
buf += pArgs->ca * sizeof(ptrdiff_t); \
9494
} \
9595
if( pArgs->cd == 0 ) pArgs->d = NULL; \
9696
else { \
@@ -101,15 +101,15 @@ typedef struct __dt_args {
101101
else pArgs->i = (int*)buf; \
102102
pArgs->ref_count = 1; \
103103
pArgs->total_pack_size = (4 + (IC) + (DC)) * sizeof(int) + \
104-
(AC) * sizeof(OPAL_PTRDIFF_TYPE); \
104+
(AC) * sizeof(ptrdiff_t); \
105105
(PDATA)->args = (void*)pArgs; \
106106
(PDATA)->packed_description = NULL; \
107107
} while(0)
108108

109109

110110
int32_t ompi_datatype_set_args( ompi_datatype_t* pData,
111111
int32_t ci, const int32_t** i,
112-
int32_t ca, const OPAL_PTRDIFF_TYPE* a,
112+
int32_t ca, const ptrdiff_t* a,
113113
int32_t cd, ompi_datatype_t* const * d, int32_t type)
114114
{
115115
int pos;
@@ -220,9 +220,9 @@ int32_t ompi_datatype_set_args( ompi_datatype_t* pData,
220220
break;
221221
}
222222

223-
/* copy the array of MPI_Aint, aka OPAL_PTRDIFF_TYPE */
223+
/* copy the array of MPI_Aint, aka ptrdiff_t */
224224
if( pArgs->a != NULL )
225-
memcpy( pArgs->a, a, ca * sizeof(OPAL_PTRDIFF_TYPE) );
225+
memcpy( pArgs->a, a, ca * sizeof(ptrdiff_t) );
226226

227227
for( pos = 0; pos < cd; pos++ ) {
228228
pArgs->d[pos] = d[pos];
@@ -317,7 +317,7 @@ int32_t ompi_datatype_print_args( const ompi_datatype_t* pData )
317317

318318
int32_t ompi_datatype_get_args( const ompi_datatype_t* pData, int32_t which,
319319
int32_t* ci, int32_t* i,
320-
int32_t* ca, OPAL_PTRDIFF_TYPE* a,
320+
int32_t* ca, ptrdiff_t* a,
321321
int32_t* cd, ompi_datatype_t** d, int32_t* type)
322322
{
323323
ompi_datatype_args_t* pArgs = (ompi_datatype_args_t*)pData->args;
@@ -354,7 +354,7 @@ int32_t ompi_datatype_get_args( const ompi_datatype_t* pData, int32_t which,
354354
memcpy( i, pArgs->i, pArgs->ci * sizeof(int) );
355355
}
356356
if( (NULL != a) && (NULL != pArgs->a) ) {
357-
memcpy( a, pArgs->a, pArgs->ca * sizeof(OPAL_PTRDIFF_TYPE) );
357+
memcpy( a, pArgs->a, pArgs->ca * sizeof(ptrdiff_t) );
358358
}
359359
if( (NULL != d) && (NULL != pArgs->d) ) {
360360
memcpy( d, pArgs->d, pArgs->cd * sizeof(MPI_Datatype) );
@@ -449,8 +449,8 @@ static inline int __ompi_datatype_pack_description( ompi_datatype_t* datatype,
449449
/* description of the displacements must be 64 bits aligned */
450450
OMPI_DATATYPE_ALIGN_PTR(next_packed, char*);
451451

452-
memcpy( next_packed, args->a, sizeof(OPAL_PTRDIFF_TYPE) * args->ca );
453-
next_packed += sizeof(OPAL_PTRDIFF_TYPE) * args->ca;
452+
memcpy( next_packed, args->a, sizeof(ptrdiff_t) * args->ca );
453+
next_packed += sizeof(ptrdiff_t) * args->ca;
454454
}
455455
position = (int*)next_packed;
456456
next_packed += sizeof(int) * args->cd;
@@ -557,7 +557,7 @@ static ompi_datatype_t* __ompi_datatype_create_from_packed_description( void** p
557557
int* position;
558558
ompi_datatype_t* datatype = NULL;
559559
ompi_datatype_t** array_of_datatype;
560-
OPAL_PTRDIFF_TYPE* array_of_disp;
560+
ptrdiff_t* array_of_disp;
561561
int* array_of_length;
562562
int number_of_length, number_of_disp, number_of_datatype, data_id;
563563
int create_type, i;
@@ -609,13 +609,13 @@ static ompi_datatype_t* __ompi_datatype_create_from_packed_description( void** p
609609
next_buffer += (4 * sizeof(int)); /* move after the header */
610610

611611
/* description of the displacements (if ANY !) should always be aligned
612-
on MPI_Aint, aka OPAL_PTRDIFF_TYPE */
612+
on MPI_Aint, aka ptrdiff_t */
613613
if (number_of_disp > 0) {
614614
OMPI_DATATYPE_ALIGN_PTR(next_buffer, char*);
615615
}
616616

617-
array_of_disp = (OPAL_PTRDIFF_TYPE*)next_buffer;
618-
next_buffer += number_of_disp * sizeof(OPAL_PTRDIFF_TYPE);
617+
array_of_disp = (ptrdiff_t*)next_buffer;
618+
next_buffer += number_of_disp * sizeof(ptrdiff_t);
619619
/* the other datatypes */
620620
position = (int*)next_buffer;
621621
next_buffer += number_of_datatype * sizeof(int);

‎ompi/datatype/ompi_datatype_create_indexed.c‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* Copyright (c) 2009 Sun Microsystems, Inc. All rights reserved.
1414
* Copyright (c) 2009 Oak Ridge National Labs. All rights reserved.
1515
* Copyright (c) 2010 Cisco Systems, Inc. All rights reserved.
16-
* Copyright (c) 2015 Research Organization for Information Science
16+
* Copyright (c) 2015-2017 Research Organization for Information Science
1717
* and Technology (RIST). All rights reserved.
1818
* $COPYRIGHT$
1919
*
@@ -35,7 +35,7 @@ int32_t ompi_datatype_create_indexed( int count, const int* pBlockLength, const
3535
{
3636
ompi_datatype_t* pdt;
3737
int i, dLength, endat, disp;
38-
OPAL_PTRDIFF_TYPE extent;
38+
ptrdiff_t extent;
3939

4040
if( 0 == count ) {
4141
return ompi_datatype_duplicate( &ompi_mpi_datatype_null.dt, newType);
@@ -66,12 +66,12 @@ int32_t ompi_datatype_create_indexed( int count, const int* pBlockLength, const
6666
}
6767

6868

69-
int32_t ompi_datatype_create_hindexed( int count, const int* pBlockLength, const OPAL_PTRDIFF_TYPE* pDisp,
69+
int32_t ompi_datatype_create_hindexed( int count, const int* pBlockLength, const ptrdiff_t* pDisp,
7070
const ompi_datatype_t* oldType, ompi_datatype_t** newType )
7171
{
7272
ompi_datatype_t* pdt;
7373
int i, dLength;
74-
OPAL_PTRDIFF_TYPE extent, disp, endat;
74+
ptrdiff_t extent, disp, endat;
7575

7676
if( 0 == count ) {
7777
*newType = ompi_datatype_create( 0 );
@@ -109,7 +109,7 @@ int32_t ompi_datatype_create_indexed_block( int count, int bLength, const int* p
109109
{
110110
ompi_datatype_t* pdt;
111111
int i, dLength, endat, disp;
112-
OPAL_PTRDIFF_TYPE extent;
112+
ptrdiff_t extent;
113113

114114
ompi_datatype_type_extent( oldType, &extent );
115115
if( (count == 0) || (bLength == 0) ) {
@@ -143,12 +143,12 @@ int32_t ompi_datatype_create_indexed_block( int count, int bLength, const int* p
143143
return OMPI_SUCCESS;
144144
}
145145

146-
int32_t ompi_datatype_create_hindexed_block( int count, int bLength, const OPAL_PTRDIFF_TYPE* pDisp,
146+
int32_t ompi_datatype_create_hindexed_block( int count, int bLength, const ptrdiff_t* pDisp,
147147
const ompi_datatype_t* oldType, ompi_datatype_t** newType )
148148
{
149149
ompi_datatype_t* pdt;
150150
int i, dLength;
151-
OPAL_PTRDIFF_TYPE extent, disp, endat;
151+
ptrdiff_t extent, disp, endat;
152152

153153
ompi_datatype_type_extent( oldType, &extent );
154154
if( (count == 0) || (bLength == 0) ) {

0 commit comments

Comments
 (0)