Skip to content

Commit d724d8a

Browse files
author
rhc54
committed
Merge pull request #1515 from kmroz/wip-ompi-info-all-2
opal_info_support: output component versions
2 parents 2bfd6a9 + 20e448c commit d724d8a

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

ompi/tools/ompi_info/ompi_info.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ int main(int argc, char *argv[])
131131
if (OMPI_ERR_BAD_PARAM == ret) {
132132
/* output what we got */
133133
opal_info_do_params(true, opal_cmd_line_is_taken(ompi_info_cmd_line, "internal"),
134-
&mca_types, NULL);
134+
&mca_types, &component_map, NULL);
135135
}
136136
exit(1);
137137
}
@@ -161,7 +161,7 @@ int main(int argc, char *argv[])
161161
if (want_all || opal_cmd_line_is_taken(ompi_info_cmd_line, "param") ||
162162
opal_cmd_line_is_taken(ompi_info_cmd_line, "params")) {
163163
opal_info_do_params(want_all, opal_cmd_line_is_taken(ompi_info_cmd_line, "internal"),
164-
&mca_types, ompi_info_cmd_line);
164+
&mca_types, &component_map, ompi_info_cmd_line);
165165
acted = true;
166166
}
167167
if (opal_cmd_line_is_taken(ompi_info_cmd_line, "type")) {

opal/runtime/opal_info_support.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,7 @@ void opal_info_do_path(bool want_all, opal_cmd_line_t *cmd_line)
429429

430430
void opal_info_do_params(bool want_all_in, bool want_internal,
431431
opal_pointer_array_t *mca_types,
432+
opal_pointer_array_t *component_map,
432433
opal_cmd_line_t *opal_info_cmd_line)
433434
{
434435
mca_base_var_info_lvl_t max_level = OPAL_INFO_LVL_1;
@@ -482,6 +483,9 @@ void opal_info_do_params(bool want_all_in, bool want_internal,
482483
/* Show the params */
483484

484485
if (want_all) {
486+
opal_info_show_component_version(mca_types, component_map, opal_info_type_all,
487+
opal_info_component_all, opal_info_ver_full,
488+
opal_info_ver_all);
485489
for (i = 0; i < mca_types->size; ++i) {
486490
if (NULL == (type = (char *)opal_pointer_array_get_item(mca_types, i))) {
487491
continue;
@@ -510,6 +514,9 @@ void opal_info_do_params(bool want_all_in, bool want_internal,
510514
exit(1);
511515
}
512516

517+
opal_info_show_component_version(mca_types, component_map, type,
518+
component, opal_info_ver_full,
519+
opal_info_ver_all);
513520
opal_info_show_mca_params(type, component, max_level, want_internal);
514521
}
515522
}

opal/runtime/opal_info_support.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ OPAL_DECLSPEC void opal_info_err_params(opal_pointer_array_t *component_map);
6868

6969
OPAL_DECLSPEC void opal_info_do_params(bool want_all_in, bool want_internal,
7070
opal_pointer_array_t *mca_type,
71+
opal_pointer_array_t *component_map,
7172
opal_cmd_line_t *opal_info_cmd_line);
7273

7374
OPAL_DECLSPEC void opal_info_show_path(const char *type, const char *value);

oshmem/tools/oshmem_info/oshmem_info.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ int main(int argc, char *argv[])
125125
if (OSHMEM_ERR_BAD_PARAM == ret) {
126126
/* output what we got */
127127
opal_info_do_params(true, opal_cmd_line_is_taken(info_cmd_line, "internal"),
128-
&mca_types, NULL);
128+
&mca_types, &component_map, NULL);
129129
}
130130
exit(1);
131131
}
@@ -151,7 +151,7 @@ int main(int argc, char *argv[])
151151
if (want_all || opal_cmd_line_is_taken(info_cmd_line, "param") ||
152152
opal_cmd_line_is_taken(info_cmd_line, "params")) {
153153
opal_info_do_params(want_all, opal_cmd_line_is_taken(info_cmd_line, "internal"),
154-
&mca_types, info_cmd_line);
154+
&mca_types, &component_map, info_cmd_line);
155155
acted = true;
156156
}
157157

0 commit comments

Comments
 (0)