Merge pull request #7189 from michaellass/fix-dims_create

jsquyres · web-flow · commit dd2d7d2866fd · 2020-01-10T09:47:09.000-05:00
dims_create: fix calculation of factors for odd squares
diff --git a/ompi/mpi/c/dims_create.c b/ompi/mpi/c/dims_create.c
@@ -240,7 +240,7 @@ getfactors(int num, int *nfactors, int **factors) {
     }
     /* determine all occurences of uneven prime numbers up to sqrt(num) */
     d = 3;
-    for(d = 3; (num > 1) && (d < sqrtnum); d += 2) {
+    for(d = 3; (num > 1) && (d <= sqrtnum); d += 2) {
         while((num % d) == 0) {
             num /= d;
             (*factors)[i++] = d;

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ getfactors(int num, int nfactors, int *factors) {`
`240`	`240`	`}`
`241`	`241`	`/* determine all occurences of uneven prime numbers up to sqrt(num) */`
`242`	`242`	`d = 3;`
`243`		`- for(d = 3; (num > 1) && (d < sqrtnum); d += 2) {`
	`243`	`+ for(d = 3; (num > 1) && (d <= sqrtnum); d += 2) {`
`244`	`244`	`while((num % d) == 0) {`
`245`	`245`	`num /= d;`
`246`	`246`	`(*factors)[i++] = d;`