opal: standardize on max hostname length

Define OPAL_MAXHOSTNAMELEN to be either:
  (MAXHOSTNAMELEN + 1) or
  (limits.h:HOST_NAME_MAX + 1) or
  (255 + 1)

For pmix code, define above using PMIX_MAXHOSTNAMELEN.

Fixup opal layer to use the new max.

Signed-off-by: Karol Mroz <[email protected]>

Author: kmroz

opal/include/opal_config_bottom.h

@@ -285,6 +285,14 @@ typedef OPAL_PTRDIFF_TYPE ptrdiff_t;
 #define OPAL_PATH_SEP "/"
 #define OPAL_ENV_SEP  ':'
 
+#if defined(MAXHOSTNAMELEN)
+#define OPAL_MAXHOSTNAMELEN (MAXHOSTNAMELEN + 1)
+#elif defined(HOST_NAME_MAX)
+#define OPAL_MAXHOSTNAMELEN (HOST_NAME_MAX + 1)
+#else
+/* SUSv2 guarantees that "Host names are limited to 255 bytes". */
+#define OPAL_MAXHOSTNAMELEN (255 + 1)
+#endif
 
 /*
  * Do we want memory debugging?
@@ -489,14 +497,9 @@ static inline uint16_t ntohs(uint16_t netvar) { return netvar; }
 #ifdef HAVE_HOSTLIB_H
 /* gethostname() */
 #include <hostLib.h>
-
-#ifndef MAXHOSTNAMELEN
-#define MAXHOSTNAMELEN 64
 #endif
 #endif
 
-#endif
-
 /* If we're in C++, then just undefine restrict and then define it to
    nothing.  "restrict" is not part of the C++ language, and we don't
    have a corresponding AC_CXX_RESTRICT to figure out what the C++

opal/mca/base/mca_base_component_find.c

@@ -330,7 +330,7 @@ static int component_find_check (mca_base_framework_t *framework, char **request
         }
 
         if (!found) {
-            char h[MAXHOSTNAMELEN];
+            char h[OPAL_MAXHOSTNAMELEN];
             gethostname(h, sizeof(h));
             opal_show_help("help-mca-base.txt",
                            "find-available:not-valid", true,

opal/mca/base/mca_base_open.c

@@ -66,7 +66,7 @@ int mca_base_open(void)
 {
     char *value;
     opal_output_stream_t lds;
-    char hostname[64];
+    char hostname[OPAL_MAXHOSTNAMELEN];
     int var_id;
 
     if (mca_base_opened++) {
@@ -137,7 +137,7 @@ int mca_base_open(void)
     } else {
         set_defaults(&lds);
     }
-    gethostname(hostname, 64);
+    gethostname(hostname, sizeof(hostname));
     asprintf(&lds.lds_prefix, "[%s:%05d] ", hostname, getpid());
     opal_output_reopen(0, &lds);
     opal_output_verbose (MCA_BASE_VERBOSE_COMPONENT, 0, "mca: base: opening components");

opal/mca/event/libevent2022/libevent/evdns.c

@@ -48,6 +48,8 @@
  * Version: 0.1b
  */
 
+#include "opal_config.h"
+
 #include <sys/types.h>
 #include "event2/event-config.h"
 
@@ -121,10 +123,6 @@
 #define EVDNS_LOG_WARN 1
 #define EVDNS_LOG_MSG 2
 
-#ifndef HOST_NAME_MAX
-#define HOST_NAME_MAX 255
-#endif
-
 #include <stdio.h>
 
 #undef MIN
@@ -3108,7 +3106,7 @@ evdns_search_ndots_set(const int ndots) {
 
 static void
 search_set_from_hostname(struct evdns_base *base) {
-	char hostname[HOST_NAME_MAX + 1], *domainname;
+	char hostname[OPAL_MAXHOSTNAMELEN], *domainname;
 
 	ASSERT_LOCKED(base);
 	search_postfix_clear(base);

opal/mca/hwloc/base/hwloc_base_util.c

@@ -399,7 +399,7 @@ int opal_hwloc_base_report_bind_failure(const char *file,
 
     if (!already_reported &&
         OPAL_HWLOC_BASE_MBFA_SILENT != opal_hwloc_base_mbfa) {
-        char hostname[64];
+        char hostname[OPAL_MAXHOSTNAMELEN];
         gethostname(hostname, sizeof(hostname));
 
         opal_show_help("help-opal-hwloc-base.txt", "mbind failure", true,

opal/mca/pmix/pmix114/pmix/examples/dynamic.c

@@ -45,12 +45,12 @@ int main(int argc, char **argv)
     uint32_t nprocs;
     char nsp2[PMIX_MAX_NSLEN+1];
     pmix_app_t *app;
-    char hostname[1024], dir[1024];
+    char hostname[PMIX_MAXHOSTNAMELEN], dir[1024];
     pmix_proc_t *peers;
     size_t npeers, ntmp=0;
     char *nodelist;
 
-    gethostname(hostname, 1024);
+    gethostname(hostname, sizeof(hostname));
     getcwd(dir, 1024);
 
     /* init us */

opal/mca/pmix/pmix114/pmix/include/pmix/autogen/pmix_config_bottom.h

@@ -258,6 +258,15 @@ typedef PMIX_PTRDIFF_TYPE ptrdiff_t;
 #define PMIX_PATH_MAX	256
 #endif
 
+#if defined(MAXHOSTNAMELEN)
+#define PMIX_MAXHOSTNAMELEN (MAXHOSTNAMELEN + 1)
+#elif defined(HOST_NAME_MAX)
+#define PMIX_MAXHOSTNAMELEN (HOST_NAME_MAX + 1)
+#else
+/* SUSv2 guarantees that "Host names are limited to 255 bytes". */
+#define PMIX_MAXHOSTNAMELEN (255 + 1)
+#endif
+
 /*
  * Set the compile-time path-separator on this system and variable separator
  */
@@ -387,12 +396,7 @@ typedef PMIX_PTRDIFF_TYPE ptrdiff_t;
 #ifdef HAVE_HOSTLIB_H
 /* gethostname() */
 #include <hostLib.h>
-
-#ifndef MAXHOSTNAMELEN
-#define MAXHOSTNAMELEN 64
-#endif
 #endif
-
 #endif
 
 /* If we're in C++, then just undefine restrict and then define it to

opal/mca/pmix/pmix114/pmix/src/util/output.c

@@ -125,7 +125,7 @@ PMIX_CLASS_INSTANCE(pmix_output_stream_t, pmix_object_t, construct, NULL);
 bool pmix_output_init(void)
 {
     int i;
-    char hostname[32];
+    char hostname[PMIX_MAXHOSTNAMELEN];
     char *str;
 
     if (initialized) {
@@ -250,7 +250,7 @@ bool pmix_output_switch(int output_id, bool enable)
 void pmix_output_reopen_all(void)
 {
     char *str;
-    char hostname[32];
+    char hostname[PMIX_MAXHOSTNAMELEN];
 
     str = getenv("PMIX_OUTPUT_STDERR_FD");
     if (NULL != str) {

opal/mca/pmix/pmix114/pmix/test/simple/simpdyn.c

@@ -49,12 +49,12 @@ int main(int argc, char **argv)
     uint32_t nprocs;
     char nsp2[PMIX_MAX_NSLEN+1];
     pmix_app_t *app;
-    char hostname[1024];
+    char hostname[PMIX_MAXHOSTNAMELEN];
     pmix_proc_t *peers;
     size_t npeers, ntmp=0;
     char *nodelist;
 
-    gethostname(hostname, 1024);
+    gethostname(hostname, sizeof(hostname));
 
     /* init us */
     if (PMIX_SUCCESS != (rc = PMIx_Init(&myproc))) {

opal/mca/pmix/pmix114/pmix/test/simple/simptest.c

@@ -316,9 +316,9 @@ static void set_namespace(int nprocs, char *ranks, char *nspace,
                           pmix_op_cbfunc_t cbfunc, myxfer_t *x)
 {
     char *regex, *ppn;
-    char hostname[1024];
+    char hostname[PMIX_MAXHOSTNAMELEN];
 
-    gethostname(hostname, 1024);
+    gethostname(hostname, sizeof(hostname));
     x->ninfo = 6;
 
     PMIX_INFO_CREATE(x->info, x->ninfo);