Fix wrong locking when freeing a continuation request

devreal · devreal · commit e366ae03667a · 2022-12-19T16:33:41.000+01:00
Signed-off-by: Joseph Schuchart &lt;schuchart@icl.utk.edu&gt;
diff --git a/ompi/mpiext/continue/c/continuation.c b/ompi/mpiext/continue/c/continuation.c
@@ -1030,11 +1030,11 @@ static int ompi_continue_request_free(ompi_request_t** cont_req_ptr)
 
     const bool using_threads = opal_using_threads();
     if (using_threads) {
-        opal_atomic_lock(&cont_req->cont_lock);
+        opal_mutex_atomic_lock(&cont_req_list_mtx);
     }
     opal_list_remove_item(&cont_req_list, &cont_req->cont_list_item);
     if (using_threads) {
-        opal_mutex_unlock(&cont_req_list_mtx);
+        opal_mutex_atomic_unlock(&cont_req_list_mtx);
     }
 
     OBJ_RELEASE(cont_req);

Original file line number	Diff line number	Diff line change
`@@ -1030,11 +1030,11 @@ static int ompi_continue_request_free(ompi_request_t** cont_req_ptr)`
`1030`	`1030`
`1031`	`1031`	`const bool using_threads = opal_using_threads();`
`1032`	`1032`	`if (using_threads) {`
`1033`		`- opal_atomic_lock(&cont_req->cont_lock);`
	`1033`	`+ opal_mutex_atomic_lock(&cont_req_list_mtx);`
`1034`	`1034`	`}`
`1035`	`1035`	`opal_list_remove_item(&cont_req_list, &cont_req->cont_list_item);`
`1036`	`1036`	`if (using_threads) {`
`1037`		`- opal_mutex_unlock(&cont_req_list_mtx);`
	`1037`	`+ opal_mutex_atomic_unlock(&cont_req_list_mtx);`
`1038`	`1038`	`}`
`1039`	`1039`
`1040`	`1040`	`OBJ_RELEASE(cont_req);`