io/ompio: fix for CID 1645292

edgargabriel · edgargabriel · commit eaf07b857e28 · 2025-04-22T17:10:26.000Z
protect a variable against potentially accessing the element -1 in an
array using an assert statement.

Signed-off-by: Edgar Gabriel &lt;Edgar.Gabriel@amd.com&gt;
diff --git a/ompi/mca/io/ompio/io_ompio_file_open.c b/ompi/mca/io/ompio/io_ompio_file_open.c
@@ -427,6 +427,7 @@ static void mca_io_ompio_file_get_eof_offset (ompio_file_t *fh,
         }
         
         offset = prev_offset;
+        assert(index_in_file_view > 0);
         blocklen = fh->f_fview.f_decoded_iov[index_in_file_view-1].iov_len;
         while (offset <= in_offset && k <= blocklen)  {
             prev_offset = offset;

Original file line number	Diff line number	Diff line change
`@@ -427,6 +427,7 @@ static void mca_io_ompio_file_get_eof_offset (ompio_file_t *fh,`
`427`	`427`	`}`
`428`	`428`
`429`	`429`	`offset = prev_offset;`
	`430`	`+ assert(index_in_file_view > 0);`
`430`	`431`	`blocklen = fh->f_fview.f_decoded_iov[index_in_file_view-1].iov_len;`
`431`	`432`	`while (offset <= in_offset && k <= blocklen) {`
`432`	`433`	`prev_offset = offset;`