orte/oob/tcp: Plug the memory leak.

artpol84 · artpol84 · commit f50888792049 · 2016-12-01T06:47:51.000+07:00
Plug coverity defect CID 1396541. (cherry-picked from bf79e83) Signed-off-by: Artem Polyakov <artpol84@gmail.com>
diff --git a/orte/mca/oob/tcp/oob_tcp_connection.c b/orte/mca/oob/tcp/oob_tcp_connection.c
@@ -862,6 +862,7 @@ int mca_oob_tcp_peer_recv_connect_ack(mca_oob_tcp_peer_t* pr,
              */
             mca_oob_tcp_peer_close(peer);
         }
+        free(msg);
         return ORTE_ERR_UNREACH;
     }
 
@@ -876,6 +877,7 @@ int mca_oob_tcp_peer_recv_connect_ack(mca_oob_tcp_peer_t* pr,
           MCA_OOB_TCP_CONNECTING == peer->state ||
          MCA_OOB_TCP_CONNECT_ACK == peer->state ) ) {
         if (retry(peer, sd, false)) {
+            free(msg);
             return ORTE_ERR_UNREACH;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -862,6 +862,7 @@ int mca_oob_tcp_peer_recv_connect_ack(mca_oob_tcp_peer_t* pr,`
`862`	`862`	`*/`
`863`	`863`	`mca_oob_tcp_peer_close(peer);`
`864`	`864`	`}`
	`865`	`+ free(msg);`
`865`	`866`	`return ORTE_ERR_UNREACH;`
`866`	`867`	`}`
`867`	`868`
`@@ -876,6 +877,7 @@ int mca_oob_tcp_peer_recv_connect_ack(mca_oob_tcp_peer_t* pr,`
`876`	`877`	`MCA_OOB_TCP_CONNECTING == peer->state \|\|`
`877`	`878`	`MCA_OOB_TCP_CONNECT_ACK == peer->state ) ) {`
`878`	`879`	`if (retry(peer, sd, false)) {`
	`880`	`+ free(msg);`
`879`	`881`	`return ORTE_ERR_UNREACH;`
`880`	`882`	`}`
`881`	`883`	`}`