Skip to content

v5.0.x: mpi/[send]recv.c: set memcheck for single-receive functions #12060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023
Merged

v5.0.x: mpi/[send]recv.c: set memcheck for single-receive functions #12060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ompi/mpi/c/recv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* Copyright (c) 2010-2012 Oak Ridge National Labs. All rights reserved.
* Copyright (c) 2015 Research Organization for Information Science
* and Technology (RIST). All rights reserved.
* Copyright (c) 2023 Jeffrey M. Squyres. All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
Expand Down Expand Up @@ -90,6 +91,12 @@ int MPI_Recv(void *buf, int count, MPI_Datatype type, int source,
if (MPI_PROC_NULL == source) {
if (MPI_STATUS_IGNORE != status) {
OMPI_COPY_STATUS(status, ompi_request_empty.req_status, false);
/*
* Per MPI-1, the MPI_ERROR field is not defined for single-completion calls
*/
MEMCHECKER(
opal_memchecker_base_mem_undefined(&status->MPI_ERROR, sizeof(int));
);
}
return MPI_SUCCESS;
}
Expand Down
7 changes: 7 additions & 0 deletions ompi/mpi/c/sendrecv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* Copyright (c) 2015 Research Organization for Information Science
* and Technology (RIST). All rights reserved.
* Copyright (c) 2021 Nanook Consulting. All rights reserved.
* Copyright (c) 2023 Jeffrey M. Squyres. All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
Expand Down Expand Up @@ -121,6 +122,12 @@ int MPI_Sendrecv(const void *sendbuf, int sendcount, MPI_Datatype sendtype,
} else {
if (MPI_STATUS_IGNORE != status) {
OMPI_COPY_STATUS(status, ompi_request_empty.req_status, false);
/*
* Per MPI-1, the MPI_ERROR field is not defined for single-completion calls
*/
MEMCHECKER(
opal_memchecker_base_mem_undefined(&status->MPI_ERROR, sizeof(int));
);
}
rc = MPI_SUCCESS;
}
Expand Down