Update opal_portable_platform_real.h from upstream gasnet #12829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull update from https://bitbucket.org/berkeleylab/gasnet/src/stable/other/gasnet_portable_platform.h at git hash a90966674. This update brings in two things: 1. Remove the need for the #define workarounds in opal/include/opal/opal_portable_platform.h 2. Remove all //-style comments, making this file safe to use with C89-style applications (per open-mpi#12710). Many thanks to the gasnet team for including these changes in their upstream repo. Note that we still need the #ifndef SIZEOF_VOID_P protection in mpi.h. This commit also makes a minor update in mpi.h[.in] to prefix an OMPI-specific #define with "OMPI_". No one has ever complained about this un-prefixed macro, but prefixing it it felt like the Right Thing to do while mucking around with other portable_platform stuff. Signed-off-by: Jeff Squyres <[email protected]>
This was referenced Sep 28, 2024
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Sep 30, 2024
See open-mpi/ompi#12829 for an explanation Signed-off-by: Ralph Castain <[email protected]>
rhc54
added a commit
to rhc54/prrte
that referenced
this pull request
Sep 30, 2024
See open-mpi/ompi#12829 for an explanation Signed-off-by: Ralph Castain <[email protected]>
rhc54
added a commit
to openpmix/prrte
that referenced
this pull request
Sep 30, 2024
See open-mpi/ompi#12829 for an explanation Signed-off-by: Ralph Castain <[email protected]>
rhc54
added a commit
to openpmix/openpmix
that referenced
this pull request
Sep 30, 2024
See open-mpi/ompi#12829 for an explanation Signed-off-by: Ralph Castain <[email protected]>
rhc54
added a commit
to rhc54/prrte
that referenced
this pull request
Sep 30, 2024
See open-mpi/ompi#12829 for an explanation Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit bff20a8)
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Sep 30, 2024
See open-mpi/ompi#12829 for an explanation Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 2412fa3)
This was referenced Sep 30, 2024
rhc54
added a commit
to openpmix/prrte
that referenced
this pull request
Sep 30, 2024
See open-mpi/ompi#12829 for an explanation Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit bff20a8)
rhc54
added a commit
to openpmix/openpmix
that referenced
this pull request
Sep 30, 2024
See open-mpi/ompi#12829 for an explanation Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 2412fa3)
hppritcha
pushed a commit
to hppritcha/prrte
that referenced
this pull request
Oct 1, 2024
See open-mpi/ompi#12829 for an explanation Signed-off-by: Ralph Castain <[email protected]> (from upstream commit bff20a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull update from
https://bitbucket.org/berkeleylab/gasnet/src/stable/other/gasnet_portable_platform.h at git hash a90966674. This update brings in two things:
Many thanks to the gasnet team for including these changes in their upstream repo.
Note that we still need the #ifndef SIZEOF_VOID_P protection in mpi.h. This commit also makes a minor update in mpi.h[.in] to prefix an OMPI-specific #define with "OMPI_". No one has ever complained about this un-prefixed macro, but prefixing it it felt like the Right Thing to do while mucking around with other portable_platform stuff.
Fixes #12710
This PR proposed as a replacement for #12811
Upstream gasnet PR where the changes went in: https://bitbucket.org/berkeleylab/gasnet/pull-requests/543