show_help: only parse specific trees for help files #13247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - I already do that since the beginning as it was just easier on my code (only one root directory). |
bosilca
reviewed
May 12, 2025
Change --root CLI param to --roots in order to accept a specific list of root directories to traverse to look for help files (rather than a single top-level root that contains all the directories that we want to traverse -- but which also contains directories that we *don't* want to traverse). Also, just for the heckuvit, parameterize the list of subdirectories to skip (via --skip-dirs). Using --roots prevents us from accidentally traversing into VPATH build directories, for example, and finding PMIx and/or PRTE help files. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/limit-show-help-generation-scanning
branch
from
4a3867d to
114cd4d
Compare
bosilca
approved these changes
May 12, 2025
bosilca
reviewed
May 12, 2025
hppritcha
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change --root CLI param to --roots in order to accept a specific list of root directories to traverse to look for help files (rather than a single top-level root that contains all the directories that we want to traverse -- but which also contains directories that we don't want to traverse). Also, just for the heckuvit, parameterize the list of subdirectories to skip (via --skip-dirs).
Using --roots prevents us from accidentally traversing into VPATH build directories, for example, and finding PMIx and/or PRTE help files.