Update usnic BTL to libfabric v1.4 #1989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
force-pushed
the
pr/update-usnic-to-libfabric-v1.4
branch
3 times, most recently
from
d39609e to
b7b14c6
Compare
|
@bturrubiates Please review. |
jsquyres
force-pushed
the
pr/update-usnic-to-libfabric-v1.4
branch
2 times, most recently
from
8577c25 to
0d4dfaa
Compare
|
|
||
| int ret; | ||
| struct fi_info *info_list_local; | ||
| ret = fi_getinfo(version, NULL, 0, 0, &hints, &info_list_local); |
There was a problem hiding this comment.
why not:
return fi_getinfo(version, NULL, 0, 0, &hints, *info_list_local);and get rid of info_list_local and ret?
There was a problem hiding this comment.
I think you meant
return fi_getinfo(version, NULL, 0, 0, &hints, info_list);But yes, you're right -- that's a bit simpler.
With libfabric v1.4, the usnic provider changed the values of its fabric and domain name strings (compared to libfabric <v1.4). Update the Open MPI usNIC BTL to handle both pre-v1.4 and v1.4 fabric/domain names. Signed-off-by: Jeff Squyres <[email protected]>
Signed-off-by: Jeff Squyres <[email protected]>
Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/update-usnic-to-libfabric-v1.4
branch
from
0d4dfaa to
f56b16f
Compare
|
@bturrubiates Pushed new commits addressing your comments. Still waiting for Travis to clear CI. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until ofiwg/libfabric#2052 is closed.