opal_check_cma: make consistent with rest of configury #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the CMA test into two parts so that the back-end test only has to be run once. Fail with --with-cma is specified and cannot be provided. Remove a few useless quotes. Change $ompi_check_cma_need_defs and $ompi_check_cma_happy to be numeric values. Finally, remove a bunch of tabs. Signed-off-by: Jeff Squyres <[email protected]>
|
@hjelmn bump |
|
Looks fine to me. I assume you tried this to make sure it works? |
|
:bot:retest Want to see the output of the various tests. The output has fallen off. |
|
@hjelmn Yes, it worked for me. I just wanted to make sure it worked for you, since you were the one who reported the issue. |
|
It looks like all the LANL-Cray resources are currently offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the CMA test into two parts so that the back-end test only has to be run once. Fail with --with-cma is specified and cannot be provided. Remove a few useless quotes. Change $ompi_check_cma_need_defs and $ompi_check_cma_happy to be numeric values. Finally, remove a bunch of tabs.
Signed-off-by: Jeff Squyres [email protected]
@hjelmn Please review and consider adding to open-mpi/ompi-release#1306.