spml/yoda: fix compiler warning #2024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is really only a partial fix. Per open-mpi#2023, the (oshmem_proc_t) and (ompi_proc_t) types should be unified properly (e.g., oshmem_proc_t should inherit an ompi_proc_t, or something like that). The fact that this code works by casting between two unrelated types is fragile and susceptible to break in the future. Signed-off-by: Jeff Squyres <[email protected]>
|
I think that this PR was made moot by #2026 and open-mpi/ompi-release#1358. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really only a partial fix. Per #2023, the (oshmem_proc_t) and (ompi_proc_t) types should be unified properly (e.g., oshmem_proc_t should inherit an ompi_proc_t, or something like that). The fact that this code works by casting between two unrelated types is fragile and susceptible to break in the future.
Signed-off-by: Jeff Squyres [email protected]