mpi/cxx: limit exposure of internal header to C++ #2062
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the #include of errhandler/errhandler.h (which includes opal_object.h). The inlude was only needed to get the extern declaration of ompi_mpi_errors_throw_exceptions. Since we have the ompi_predefined_errhandler_t in mpi.h we can declare the extern in mpicxx.c without needing the C errhandler header. This should fix open-mpi#2055 Signed-off-by: Nathan Hjelm <[email protected]>
|
@jsquyres See any problem with this? There are probably other headers that cause problems but this is the problem in this instance. |
|
Hmm, this only fixes the one file. We will run into issues with comm.cc and file.cc. Going to think about this a little more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the #include of errhandler/errhandler.h (which
includes opal_object.h). The inlude was only needed to get the extern
declaration of ompi_mpi_errors_throw_exceptions. Since we have the
ompi_predefined_errhandler_t in mpi.h we can declare the extern in
mpicxx.c without needing the C errhandler header.
This should fix #2055
Signed-off-by: Nathan Hjelm [email protected]