osc/rdma: make locking code more robust #3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under heavy load the locking code could fail if the underlying btl module started to return OPAL_ERR_OUT_OF_RESOURCE on atomic operations. This commit updates the code to gracefully handle btl errors. Signed-off-by: Nathan Hjelm <[email protected]> (cherry picked from commit 4707c7c) Signed-off-by: Nathan Hjelm <[email protected]>
Member
Author
|
@jsquyres Found this bug during stress testing. |
regrant
approved these changes
Feb 28, 2017
Contributor
regrant
left a comment
regrant
left a comment
There was a problem hiding this comment.
This code looks fine, and solves the stated problem.
Signed-off-by: Nathan Hjelm <[email protected]> (cherry picked from commit 032bcf9) Signed-off-by: Nathan Hjelm <[email protected]>
Member
Author
|
@jsquyres Added the commit to clean up the warnings. Good to go now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under heavy load the locking code could fail if the underlying btl
module started to return OPAL_ERR_OUT_OF_RESOURCE on atomic
operations. This commit updates the code to gracefully handle btl
errors.
Signed-off-by: Nathan Hjelm [email protected]
(cherry picked from commit 4707c7c)
Signed-off-by: Nathan Hjelm [email protected]