Skip to content

Conversation

@hppritcha
Copy link
Member

@hppritcha hppritcha commented Feb 27, 2017

JMS note some questions (grep for JMS).

Signed-off-by: Howard Pritchard [email protected]

[skip ci]
bot:notest

README Outdated
the corresponding BTLs will be selected. Users can force the use
above transports can be used, unless OpenUCX or MXM support is detected,
in which case the "ucx" or "yalla" the PML will be used by default. Otherwise,
"ob1" will be used and the corresponding BTLs will be selected. Users can force the use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to re-flow this paragraph.

NEWS Outdated
for non-contiguous datatypes.
- mtl_ofi_control_prog_type/mtl_ofi_data_prog_type: specify libfabric
progress model to be used for control and data
- Add support for non-contiguous datatypes to the Portals 4 OSC.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably say "one-sided component" here (I don't think "OSC" is a well-known acronym outside of the developer community).

NEWS Outdated
- Various improvements to the Portals 4 MTL, to include adding support
for non-contiguous datatypes.
- mtl_ofi_control_prog_type/mtl_ofi_data_prog_type: specify libfabric
progress model to be used for control and data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing period at end of sentence.

NEWS Outdated
orphan children nodes in the launch tree.
- Fix the help message when showing deprecated MCA param names to show
the correct (i.e., deprecated) name.
- Enable support for OpenIB BTL use across different IB subnets.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we more-or-less uniformly refer to it as the "openib" BTL (lower case).

NEWS Outdated
Changes in behavior compared to prior versions:

- Added a timeout option to mpirun command line: number of
seconds for mpirun to wait for a job to complete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is a minor new feature, not a new behavior.

NEWS Outdated
- MPI_IREDUCE[_SCATTER]
- Thanks to all the users who helped diagnose these issues.
JMS - WERE ANY OF THESE NOT FIXED in 2.0.X? See below for numerous
citations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; I missed the de-duplication. I think ALLGATHER[V] and IALLTOALL* were cited below, but I didn't see [I][GATHER|SCATTER][V] or IREDUCE[_SCATTER].

@jsquyres
Copy link
Member

See hppritcha#1.

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to commit for the next round.

@jsquyres
Copy link
Member

@hppritcha I assume you are going to squash all 3 of those commits into 1.

@jsquyres
Copy link
Member

Howard: I merged a minor NEWS update via #3068 which may cause conflicts with this PR (i.e., you may need to rebase on top of #3068 first). Sorry! ☹️

@hppritcha hppritcha force-pushed the topic/news_updates_for_2.1.0 branch 3 times, most recently from 68de357 to ec631fa Compare March 2, 2017 17:59
@hppritcha
Copy link
Member Author

@jsquyres want to take a final look (still need to update the date in NEWS)

for the 2.1.0 release

Signed-off-by: Jeff Squyres <[email protected]>
Signed-off-by: Howard Pritchard <[email protected]>
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments:

  1. Should probably change Feb to March in README
  2. Is the list of frameworks at the bottom of README still current?

@jsquyres jsquyres merged commit 083a73b into open-mpi:v2.x Mar 2, 2017
@hppritcha hppritcha deleted the topic/news_updates_for_2.1.0 branch May 2, 2018 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants