- 
                Notifications
    You must be signed in to change notification settings 
- Fork 929
NEWS and README updates #3058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEWS and README updates #3058
Conversation
        
          
                README
              
                Outdated
          
        
      | the corresponding BTLs will be selected. Users can force the use | ||
| above transports can be used, unless OpenUCX or MXM support is detected, | ||
| in which case the "ucx" or "yalla" the PML will be used by default. Otherwise, | ||
| "ob1" will be used and the corresponding BTLs will be selected. Users can force the use | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to re-flow this paragraph.
        
          
                NEWS
              
                Outdated
          
        
      | for non-contiguous datatypes. | ||
| - mtl_ofi_control_prog_type/mtl_ofi_data_prog_type: specify libfabric | ||
| progress model to be used for control and data | ||
| - Add support for non-contiguous datatypes to the Portals 4 OSC. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably say "one-sided component" here (I don't think "OSC" is a well-known acronym outside of the developer community).
        
          
                NEWS
              
                Outdated
          
        
      | - Various improvements to the Portals 4 MTL, to include adding support | ||
| for non-contiguous datatypes. | ||
| - mtl_ofi_control_prog_type/mtl_ofi_data_prog_type: specify libfabric | ||
| progress model to be used for control and data | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing period at end of sentence.
        
          
                NEWS
              
                Outdated
          
        
      | orphan children nodes in the launch tree. | ||
| - Fix the help message when showing deprecated MCA param names to show | ||
| the correct (i.e., deprecated) name. | ||
| - Enable support for OpenIB BTL use across different IB subnets. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we more-or-less uniformly refer to it as the "openib" BTL (lower case).
        
          
                NEWS
              
                Outdated
          
        
      | Changes in behavior compared to prior versions: | ||
|  | ||
| - Added a timeout option to mpirun command line: number of | ||
| seconds for mpirun to wait for a job to complete | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is a minor new feature, not a new behavior.
        
          
                NEWS
              
                Outdated
          
        
      | - MPI_IREDUCE[_SCATTER] | ||
| - Thanks to all the users who helped diagnose these issues. | ||
| JMS - WERE ANY OF THESE NOT FIXED in 2.0.X? See below for numerous | ||
| citations. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch; I missed the de-duplication. I think ALLGATHER[V] and IALLTOALL* were cited below, but I didn't see [I][GATHER|SCATTER][V] or IREDUCE[_SCATTER].
| See hppritcha#1. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to commit for the next round.
| @hppritcha I assume you are going to squash all 3 of those commits into 1. | 
68de357    to
    ec631fa      
    Compare
  
    | @jsquyres want to take a final look (still need to update the date in NEWS) | 
for the 2.1.0 release Signed-off-by: Jeff Squyres <[email protected]> Signed-off-by: Howard Pritchard <[email protected]>
ec631fa    to
    6bb4a34      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments:
- Should probably change Feb to March in README
- Is the list of frameworks at the bottom of README still current?
JMS note some questions (grep for JMS).
Signed-off-by: Howard Pritchard [email protected]
[skip ci]
bot:notest