From b1c52a7c05520366686166ecb6420f5237c1b0f5 Mon Sep 17 00:00:00 2001 From: Valentin Petrov Date: Tue, 14 Mar 2017 10:56:14 +0200 Subject: [PATCH] Fixes the coll_allgather usage bug One should use the correct module object when calling c_coll.coll_allgather. Otherwise there will be a segfault in the case, for example, when hcoll is used. In that case c_coll.coll_allgather = mca_coll_hcoll_allgather while c_coll.coll_gather_module = tuned. Signed-off-by: Valentin Petrov --- ompi/mca/osc/rdma/osc_rdma_component.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ompi/mca/osc/rdma/osc_rdma_component.c b/ompi/mca/osc/rdma/osc_rdma_component.c index c951a767610..4a99f1a49e5 100644 --- a/ompi/mca/osc/rdma/osc_rdma_component.c +++ b/ompi/mca/osc/rdma/osc_rdma_component.c @@ -881,7 +881,7 @@ static int ompi_osc_rdma_share_data (ompi_osc_rdma_module_t *module) if (ompi_comm_size (module->local_leaders) > 1) { ret = module->local_leaders->c_coll.coll_allgather (MPI_IN_PLACE, module->region_size, MPI_BYTE, module->node_comm_info, module->region_size, MPI_BYTE, module->local_leaders, - module->local_leaders->c_coll.coll_gather_module); + module->local_leaders->c_coll.coll_allgather_module); if (OMPI_SUCCESS != ret) { OSC_RDMA_VERBOSE(MCA_BASE_VERBOSE_ERROR, "leader allgather failed with ompi error code %d", ret); break;