Skip to content

v3.1.x: Update to PMIx v2.1.2 #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 13, 2018
Merged

v3.1.x: Update to PMIx v2.1.2 #5386

merged 4 commits into from
Jul 13, 2018

Conversation

@rhc54
Copy link
Contributor

@rhc54 rhc54 commented Jul 6, 2018

Plus cleanup some errors and warnings

Ralph Castain added 2 commits July 6, 2018 15:17
Update to PMIx v2.1.2
386ae5a 
Signed-off-by: Ralph Castain <[email protected]>
Cleanup the MPI_Finalize_c/f tests
f5e61b4 
Fix a few errors:

* copy the key across for calls to PMIx job_control
* re-initialize orte_process_info.aliases in case someone foolishly re-calls orte_init
* protect the ompi errcodes in case someone foolishly re-calls MPI_Init

Signed-off-by: Ralph Castain <[email protected]>
(cherry picked from commit a87baec)
@rhc54 rhc54 added this to the v3.1.2 milestone Jul 6, 2018
@rhc54 rhc54 self-assigned this Jul 6, 2018
@rhc54 rhc54 requested a review from jjhursey July 6, 2018 22:21
Ralph Castain added 2 commits July 6, 2018 20:32
Silence a bunch of warnings
742c1c2 
Unused variables and an errant '&'

Signed-off-by: Ralph Castain <[email protected]>
(cherry picked from commit f19bfc0)
Silence warnings
8431a00 
Signed-off-by: Ralph Castain <[email protected]>
@open-mpi open-mpi deleted a comment from ibm-ompi Jul 7, 2018
@open-mpi open-mpi deleted a comment from ibm-ompi Jul 7, 2018
@open-mpi open-mpi deleted a comment from ibm-ompi Jul 7, 2018
@rhc54
Copy link
Contributor Author

rhc54 commented Jul 7, 2018

MTT before PR:

| Phase       | Section         | MPI Version | Duration | Pass | Fail | Time out | Skip | Detailed report                                                          |
+-------------+-----------------+-------------+----------+------+------+----------+------+--------------------------------------------------------------------------+
| MPI Install | my installation | 3.1.2a1     | 00:00    | 1    |      |          |      | MPI_Install-my_installation-my_installation-3.1.2a1-my_installation.html |
| Test Build  | trivial         | 3.1.2a1     | 00:01    | 1    |      |          |      | Test_Build-trivial-my_installation-3.1.2a1-my_installation.html          |
| Test Build  | ibm             | 3.1.2a1     | 00:41    | 1    |      |          |      | Test_Build-ibm-my_installation-3.1.2a1-my_installation.html              |
| Test Build  | intel           | 3.1.2a1     | 00:31    | 1    |      |          |      | Test_Build-intel-my_installation-3.1.2a1-my_installation.html            |
| Test Build  | orte            | 3.1.2a1     | 00:00    | 1    |      |          |      | Test_Build-orte-my_installation-3.1.2a1-my_installation.html             |
| Test Run    | trivial         | 3.1.2a1     | 00:03    | 2    |      |          |      | Test_Run-trivial-my_installation-3.1.2a1-my_installation.html            |
| Test Run    | ibm             | 3.1.2a1     | 09:33    | 396  |      |          |      | Test_Run-ibm-my_installation-3.1.2a1-my_installation.html                |
| Test Run    | spawn           | 3.1.2a1     | 00:10    | 7    |      |          | 1    | Test_Run-spawn-my_installation-3.1.2a1-my_installation.html              |
| Test Run    | loopspawn       | 3.1.2a1     | 10:01    | 1    |      |          |      | Test_Run-loopspawn-my_installation-3.1.2a1-my_installation.html          |
| Test Run    | intel           | 3.1.2a1     | 12:28    | 242  |      |          | 2    | Test_Run-intel-my_installation-3.1.2a1-my_installation.html              |
| Test Run    | intel_skip      | 3.1.2a1     | 09:18    | 222  |      |          | 22   | Test_Run-intel_skip-my_installation-3.1.2a1-my_installation.html         |
| Test Run    | orte            | 3.1.2a1     | 00:44    | 19   |      |          |      | Test_Run-orte-my_installation-3.1.2a1-my_installation.html               |
+-------------+-----------------+-------------+----------+------+------+----------+------+--------------------------------------------------------------------------+


    Total Tests:    894
    Total Failures: 0
    Total Passed:   894
    Total Duration: 2610 secs. (43:30)

@rhc54
Copy link
Contributor Author

rhc54 commented Jul 7, 2018

MTT with this PR:

+-------------+-----------------+-------------+----------+------+------+----------+------+--------------------------------------------------------------------------+
| Phase       | Section         | MPI Version | Duration | Pass | Fail | Time out | Skip | Detailed report                                                          |
+-------------+-----------------+-------------+----------+------+------+----------+------+--------------------------------------------------------------------------+
| MPI Install | my installation | 3.1.2a1     | 00:01    | 1    |      |          |      | MPI_Install-my_installation-my_installation-3.1.2a1-my_installation.html |
| Test Build  | trivial         | 3.1.2a1     | 00:01    | 1    |      |          |      | Test_Build-trivial-my_installation-3.1.2a1-my_installation.html          |
| Test Build  | ibm             | 3.1.2a1     | 00:39    | 1    |      |          |      | Test_Build-ibm-my_installation-3.1.2a1-my_installation.html              |
| Test Build  | intel           | 3.1.2a1     | 00:31    | 1    |      |          |      | Test_Build-intel-my_installation-3.1.2a1-my_installation.html            |
| Test Build  | orte            | 3.1.2a1     | 00:01    | 1    |      |          |      | Test_Build-orte-my_installation-3.1.2a1-my_installation.html             |
| Test Run    | trivial         | 3.1.2a1     | 00:02    | 2    |      |          |      | Test_Run-trivial-my_installation-3.1.2a1-my_installation.html            |
| Test Run    | ibm             | 3.1.2a1     | 09:24    | 396  |      |          |      | Test_Run-ibm-my_installation-3.1.2a1-my_installation.html                |
| Test Run    | spawn           | 3.1.2a1     | 00:10    | 7    |      |          | 1    | Test_Run-spawn-my_installation-3.1.2a1-my_installation.html              |
| Test Run    | loopspawn       | 3.1.2a1     | 10:05    | 1    |      |          |      | Test_Run-loopspawn-my_installation-3.1.2a1-my_installation.html          |
| Test Run    | intel           | 3.1.2a1     | 12:33    | 242  |      |          | 2    | Test_Run-intel-my_installation-3.1.2a1-my_installation.html              |
| Test Run    | intel_skip      | 3.1.2a1     | 09:08    | 222  |      |          | 22   | Test_Run-intel_skip-my_installation-3.1.2a1-my_installation.html         |
| Test Run    | orte            | 3.1.2a1     | 00:44    | 19   |      |          |      | Test_Run-orte-my_installation-3.1.2a1-my_installation.html               |
+-------------+-----------------+-------------+----------+------+------+----------+------+--------------------------------------------------------------------------+


    Total Tests:    894
    Total Failures: 0
    Total Passed:   894
    Total Duration: 2599 secs. (43:19)

@jsquyres jsquyres changed the title Update to PMIx v2.1.2 v3.1.x: Update to PMIx v2.1.2 Jul 9, 2018
@jsquyres jsquyres mentioned this pull request Jul 9, 2018
Closed
@jsquyres
Copy link
Member

jsquyres commented Jul 10, 2018

@bwbarrett FWIW, I'm good with this. It went in on v3.0.x already.

@bwbarrett bwbarrett merged commit a997e63 into open-mpi:v3.1.x Jul 13, 2018
@rhc54 rhc54 deleted the cmr31/pmix212 branch September 21, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jjhursey jjhursey jjhursey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rhc54 rhc54

Labels

bug RM approved Target: v3.1.x

Projects

None yet

Milestone

v3.1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@rhc54 @jsquyres @jjhursey @bwbarrett