ATOMIC/MXM: fixed abstraction violation - v3.1 #5424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoopoepg
changed the title
hoopoepg
force-pushed
the
topic/atomic-mxm-abstraction-viola
branch
from
b6c47ff to
5e5f6e6
Compare
- applied workaround for incorrect dynamic module dependency Signed-off-by: Sergey Oblomov <[email protected]> (cherry picked from commit d51426f)
hoopoepg
force-pushed
the
topic/atomic-mxm-abstraction-viola
branch
from
5e5f6e6 to
66db966
Compare
|
Adding the WIP-DNM! tag to remind us not to merge until #5425 is merged. We really shouldn't have PRs to both master and a release branch open at the same time. |
|
@bwbarrett #5425 is merged. Ok to merge it too? |
|
@hoopoepg All PRs on release branches need a review. |
yosefe
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar fix as for #5380
picked up from #5425
Signed-off-by: Sergey Oblomov [email protected]