Merge pull request #22 from open-olive/SIDE-1021-loop-not-shutdown

DrewRepaskyOlive · web-flow · commit 26d7d4238bf1 · 2020-12-01T17:13:34.000Z
fix for bad access: nil dereference
diff --git a/ldk/go/uiClient.go b/ldk/go/uiClient.go
@@ -29,7 +29,7 @@ func (u *UIClient) ListenSearchbar(ctx context.Context, handler ListenSearchHand
 				break
 			}
 			if err != nil {
-				handler(resp.Text, err)
+				handler("", err)
 				return
 			}
 			if resp.GetError() != "" {
@@ -58,7 +58,7 @@ func (u *UIClient) ListenGlobalSearch(ctx context.Context, handler ListenSearchH
 				break
 			}
 			if err != nil {
-				handler(resp.Text, err)
+				handler("", err)
 				return
 			}
 			if resp.GetError() != "" {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ func (u *UIClient) ListenSearchbar(ctx context.Context, handler ListenSearchHand`
`29`	`29`	`break`
`30`	`30`	`}`
`31`	`31`	`if err != nil {`
`32`		`- handler(resp.Text, err)`
	`32`	`+ handler("", err)`
`33`	`33`	`return`
`34`	`34`	`}`
`35`	`35`	`if resp.GetError() != "" {`
`@@ -58,7 +58,7 @@ func (u *UIClient) ListenGlobalSearch(ctx context.Context, handler ListenSearchH`
`58`	`58`	`break`
`59`	`59`	`}`
`60`	`60`	`if err != nil {`
`61`		`- handler(resp.Text, err)`
	`61`	`+ handler("", err)`
`62`	`62`	`return`
`63`	`63`	`}`
`64`	`64`	`if resp.GetError() != "" {`