Skip to content

Commit 30f601c

Browse files
authored
Merge pull request #27 from open-olive/SIDE-1045/fix-linting-error
[SIDE-1045] Correct linting rule, remove unnecessary disables
2 parents 8aa3de4 + d4f08cc commit 30f601c

20 files changed

+7
-30
lines changed

ldk/node/.eslintrc.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ module.exports = {
3636
'`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
3737
},
3838
],
39+
// The no-shadow rule set in airbnb-base generates false positives with TS.
40+
// https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-shadow.md
41+
'no-shadow': 'off',
42+
'@typescript-eslint/no-shadow': ['error'],
3943
'no-underscore-dangle': 'off',
4044
'no-console': ['off', { allow: ['warn', 'error'] }],
4145
'unicode-bom': 'off',

ldk/node/dist/access.js

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ldk/node/dist/brokerGrpcServer.d.ts

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ldk/node/dist/brokerGrpcServer.js

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ldk/node/dist/categories.js

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ldk/node/dist/hostClients/fileSystemService.js

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ldk/node/dist/hostClients/processService.js

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ldk/node/dist/hostClients/whisperService.js

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ldk/node/dist/hostClients/windowService.js

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ldk/node/dist/logging.js

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)