Example for "Manual Trigger for Bundle Reload" seems incomplete

[victoraugustolls]

Hi! I have the need to use manual reload for bundles in my application, as I need to sync its reload with other tasks, and I noticed a behavior with the example that makes me think that it is incomplete, so I decided to open as a discussion to see if thats expected or a bug. If it is a bug, I can open an issue.

The example can be found here, but the code is:

options := sdk.Options{
    Config: bytes.NewReader(config),
    Logger: logger,
    Ready:  make(chan struct{}), // <-- needed or else sdk.New will block
}

opa, err := sdk.New(ctx, options)
if err != nil {
    log.Fatal(err)
}
defer opa.Stop(ctx)

bundle, ok := opa.Plugin("bundle").(*bundle.Plugin)
if !ok {
    log.Fatal("bundle plugin not found")
}

err = bundle.Trigger(ctx)
if err != nil {
    log.Fatal(err)
}

The issue is that the error returned by bundle.Trigger(ctx) can be nil and at the same time the bundle was not loaded. This happens because if there's an ast error, the parser fails internally, the error status is set on the "bundle" plugin status, but no error is returned. I know one can get the error by registering a listener in the bundle plugin, but the example is a little bit misleading because either:

1. It's incomplete and should cover the error of loading the bundle by registering a listener.
2. It's a bug and the error should be returned.

You can find the error status being set here.

[victoraugustolls]

hello @anderseknert ! Do you mind sharing your thoughts here? If you are not the right person to tag, I'm sorry! And if thats the case, can you point me to the right person?

[anderseknert]

Sorry Victor, I had somehow missed this before. That sounds like a bug to me, so I'd suggest you file an issue. If it's not a bug then there's clearly work to be done one documenting how this works. So an issue seems appropriate either way.