Add tests for finish --break and utility functions

- Add bats tests for --break flag with and without duration
- Add Go unit tests for parseDurationMinutes using testify
- Fix missing trailing newline in cmd/util.go
- Add short flag -b for --break option
- Use TrimSpace to properly handle NoOptDefVal

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: justincampbell

cmd/finish.go

@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"fmt"
+	"strings"
 	"time"
 
 	"github.com/open-pomodoro/openpomodoro-cli/format"
@@ -18,7 +19,8 @@ func init() {
 		RunE:  finishCmd,
 	}
 
-	command.Flags().StringVar(&breakFlag, "break", "", "take a break after finishing (duration in minutes)")
+	command.Flags().StringVarP(&breakFlag, "break", "b", "", "take a break after finishing (duration in minutes)")
+	command.Flags().Lookup("break").NoOptDefVal = " "
 
 	RootCmd.AddCommand(command)
 }
@@ -43,9 +45,10 @@ func finishCmd(cmd *cobra.Command, args []string) error {
 	if cmd.Flags().Changed("break") {
 		breakDuration := settings.DefaultBreakDuration
 
-		if breakFlag != "" {
+		trimmedFlag := strings.TrimSpace(breakFlag)
+		if trimmedFlag != "" {
 			var err error
-			breakDuration, err = parseDurationMinutes(breakFlag)
+			breakDuration, err = parseDurationMinutes(trimmedFlag)
 			if err != nil {
 				return err
 			}

cmd/util.go

@@ -27,4 +27,4 @@ func parseDurationMinutes(s string) (time.Duration, error) {
 		s = fmt.Sprintf("%sm", s)
 	}
 	return time.ParseDuration(s)
-}
+}

cmd/util_test.go

@@ -0,0 +1,66 @@
+package cmd
+
+import (
+	"testing"
+	"time"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestParseDurationMinutes(t *testing.T) {
+	tests := []struct {
+		name     string
+		input    string
+		expected time.Duration
+		wantErr  bool
+	}{
+		{
+			name:     "integer defaults to minutes",
+			input:    "5",
+			expected: 5 * time.Minute,
+		},
+		{
+			name:     "explicit minutes",
+			input:    "10m",
+			expected: 10 * time.Minute,
+		},
+		{
+			name:     "seconds",
+			input:    "30s",
+			expected: 30 * time.Second,
+		},
+		{
+			name:     "hours",
+			input:    "1h",
+			expected: 1 * time.Hour,
+		},
+		{
+			name:     "complex duration",
+			input:    "1h30m",
+			expected: 90 * time.Minute,
+		},
+		{
+			name:    "invalid duration",
+			input:   "invalid",
+			wantErr: true,
+		},
+		{
+			name:     "zero",
+			input:    "0",
+			expected: 0,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := parseDurationMinutes(tt.input)
+			if tt.wantErr {
+				require.Error(t, err)
+			} else {
+				require.NoError(t, err)
+				assert.Equal(t, tt.expected, got)
+			}
+		})
+	}
+}

test/finish.bats

@@ -43,3 +43,19 @@ load test_helper
     [ "$status" -eq 0 ]
     assert_file_empty "current"
 }
+
+@test "finish --break flag is accepted" {
+    create_hook "break" 'exit 1'
+
+    pomodoro start "Task" --ago 1m
+    run pomodoro finish --break
+    [ "$status" -ne 0 ]
+}
+
+@test "finish --break with custom duration is accepted" {
+    create_hook "break" 'exit 1'
+
+    pomodoro start "Task" --ago 1m
+    run pomodoro finish --break 5
+    [ "$status" -ne 0 ]
+}