Merge pull request #211 from open-runtimes/refactor-delete-stats

refactor: delete stats

Author: loks0n

README.md

@@ -139,7 +139,7 @@ docker compose down
 | GET |`/v1/runtimes/{runtimeId}`| Get a runtime by its ID | [JSON](#v1runtimesruntimeid) |
 | DELETE |`/v1/runtimes/{runtimeId}`| Delete a runtime | [JSON](#v1runtimesruntimeid) |
 | POST |`/v1/runtimes/{runtimeId}/executions`| Create an execution | [JSON](#v1runtimesruntimeidexecutions) |
-| GET |`/v1/health`| Get health status of host machine and runtimes | X |
+| GET |`/v1/health`| Get health status | X |
 
 #### /v1/runtimes/{runtimeId}/logs
 | Param | Type | Description | Required | Default |

app/controllers.php

@@ -308,16 +308,10 @@ function (
     );
 
 Http::get('/v1/health')
-    ->desc("Get health status of host machine and runtimes.")
-    ->inject('runner')
+    ->desc("Get health status")
     ->inject('response')
-    ->action(function (Runner $runner, Response $response) {
-        $stats = $runner->getStats();
-        $output = [
-            'usage' => $stats->getHostUsage(),
-            'runtimes' => $stats->getContainerUsage(),
-        ];
-        $response->setStatusCode(Response::STATUS_CODE_OK)->json($output);
+    ->action(function (Response $response) {
+        $response->setStatusCode(Response::STATUS_CODE_OK)->text("OK");
     });
 
 Http::init()

src/Executor/Runner/Adapter.php

@@ -2,7 +2,6 @@
 
 namespace OpenRuntimes\Executor\Runner;
 
-use OpenRuntimes\Executor\Stats;
 use Utopia\Http\Response;
 use Utopia\Logger\Log;
 
@@ -115,6 +114,4 @@ abstract public function createExecution(
     abstract public function getRuntimes(): mixed;
 
     abstract public function getRuntime(string $name): mixed;
-
-    abstract public function getStats(): Stats;
 }

src/Executor/Runner/Docker.php

@@ -6,9 +6,7 @@
 use Appwrite\Runtimes\Runtimes as AppwriteRuntimes;
 use OpenRuntimes\Executor\Exception;
 use OpenRuntimes\Executor\Runner\Repository\Runtimes;
-use OpenRuntimes\Executor\Stats;
 use OpenRuntimes\Executor\StorageFactory;
-use OpenRuntimes\Executor\Usage;
 use OpenRuntimes\Executor\Validator\TCP;
 use Swoole\Process;
 use Swoole\Timer;
@@ -26,8 +24,6 @@
 
 class Docker extends Adapter
 {
-    private Stats $stats;
-
     /**
      * @param Orchestration $orchestration
      * @param Runtimes $runtimes
@@ -38,7 +34,6 @@ public function __construct(
         private readonly Runtimes $runtimes,
         private readonly NetworkManager $networkManager
     ) {
-        $this->stats = new Stats();
         $this->init();
     }
 
@@ -132,25 +127,6 @@ private function init(): void
 
         Console::success('Maintenance interval started.');
 
-        /**
-         * Get usage stats every X seconds to update swoole table
-         */
-        Console::info('Starting stats interval...');
-        $getStats = function (): void {
-            // Get usage stats
-            $usage = new Usage($this->orchestration);
-            $usage->run();
-            $this->stats->updateStats($usage);
-        };
-
-        // Load initial stats in blocking way
-        $getStats();
-
-        // Setup infinite recursion in non-blocking way
-        \go(fn () => Timer::after(1000, fn () => $getStats()));
-
-        Console::success('Stats interval started.');
-
         Process::signal(SIGINT, fn () => $this->cleanUp());
         Process::signal(SIGQUIT, fn () => $this->cleanUp());
         Process::signal(SIGKILL, fn () => $this->cleanUp());
@@ -1236,9 +1212,4 @@ public function getRuntime(string $name): mixed
 
         return $runtime->toArray();
     }
-
-    public function getStats(): Stats
-    {
-        return $this->stats;
-    }
 }