Skip to content

Commit 50fa8cf

Browse files
authored
Merge pull request #71 from oslabs-beta/drew/readme
Drew/readme
2 parents 47d7a02 + 8c778be commit 50fa8cf

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,11 @@ npm run test
174174
Read our [contributing guide](https://github.com/open-source-labs/Docketeer/blob/master/CONTRIBUTING.md) for more information on how to purpose bugfixes and improvements to Docketeer.
175175

176176
### Authors
177+
- Sarah Moosa [@Sbethm](https://github.com/Sbethm) | [LinkedIn](https://www.linkedin.com/in/sarah-moosa-4b05721b6/)
178+
- Cedar Cooper [@CedarCooper](https://github.com/CedarCooper) | [LinkedIn](https://www.linkedin.com/in/cedar-cooper/)
179+
- Tiffany Chau [@tiffanynchau](https://github.com/tiffanynchau/) | [LinkedIn](https://www.linkedin.com/in/tiffanynchau/)
180+
- Jack Yuan [@jackyuan1](https://github.com/jackyuan1) | [LinkedIn](https://www.linkedin.com/in/jack-yuan-298244247/)
181+
- Drew Manley [@DrewManley](https://github.com/DrewManley) | [LinkedIn](https://www.linkedin.com/in/andrewmanley13/)
177182
- Abigail Gerig [@4estgirl](https://github.com/4estgirl) | [Linkedin](https://www.linkedin.com/in/abigail-gerig/)
178183
- Trine Medina [@TrineMedina](https://github.com/TrineMedina) | [Linkedin](https://www.linkedin.com/in/trinemedina/)
179184
- Christian Looff [@cmlooff](https://github.com/cmlooff) | [LinkedIn](https://www.linkedin.com/in/christian-looff/)

src/components/helper/commands.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export const addRunning = (runningList, callback) => {
5353
}
5454
isInTheList ? '' : newList.push(convertedValue[i]);
5555
}
56-
console.log('addrunning newlist', newList);
56+
// console.log('addrunning newlist', newList);
5757
newList.length ? callback(newList) : '';
5858
}
5959
);
@@ -242,7 +242,11 @@ export const runStopped = (
242242
export const runIm = (container, runningList, callback_1, callback_2) => {
243243
// props.runIm(ele['imgid'], props.runningList, helper.addRunning, props.addRunningContainers)
244244
const { imgid, reps, tag } = container;
245-
window.nodeMethod.runExec(`docker run --name ${reps}-${tag} ${reps}:${tag}`, (error, stdout, stderr) => {
245+
const containerId = Math.floor(Math.random() * 100)
246+
const filteredRepo = reps
247+
.replace(/[,\/#!$%\^&\*;:{}=\`~()]/g, ".")
248+
.replace(/\s{2,}/g, " ");
249+
window.nodeMethod.runExec(`docker run --name ${filteredRepo}-${tag}_${containerId} ${reps}:${tag}`, (error, stdout, stderr) => {
246250
if (error) {
247251
alert(`${error.message}`);
248252
return;

src/main/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ function createMainWindow() {
2929

3030
if (process.env.NODE_ENV === 'development') {
3131
mainWindow.loadURL(`http://localhost:4000`);
32-
mainWindow.webContents.openDevTools()
32+
// mainWindow.webContents.openDevTools()
3333
} else {
3434
mainWindow.loadURL(
3535
url.format({

0 commit comments

Comments
 (0)