Skip to content

Commit 7352c1f

Browse files
committed
commit before pushing and merging
1 parent 538936b commit 7352c1f

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.env.example

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55

66
SLACK_CLIENT_SECRET = "ENTER_CLIENT_SECRET_HERE"
77
SLACK_CLIENT_ID = "ENTER_CLIENT_ID_HERE"
8-
SLACK_REDIRECT_URI = "REDIRECT URL HERE"
8+
SLACK_REDIRECT_URI = "REDIRECT URL HERE Currently 'overvuedev://test' for .env and 'overvue://slack' for .env.development"
99

1010
# https://www.npmjs.com/package/dotenv
11-
# https://www.npmjs.com/package/quasar-dotenv
11+
# https://www.npmjs.com/package/quasar-dotenv
1212
# https://v1.quasar.dev/quasar-cli/handling-process-env
13-
# https://v1.quasar.dev/quasar-cli/quasar-conf-js#using-dotenv
13+
# https://v1.quasar.dev/quasar-cli/quasar-conf-js#using-dotenv

src-electron/main-process/electron-main.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,11 @@ For Sign In with Slack, but we are now using the Add to Slack feature instead
128128
// }
129129

130130
// Turns on event listener for Slack Oauth deep linking back app
131-
// TODO: Deep linking currently doesn't work properly in dev mode - requires fix
131+
// TODO: Deep linking currently doesn't work properly in dev mode on windows - requires fix
132132

133133
function setOauthListener() {
134-
logEverywhere(`process.env.SLACK_CLIENT_ID in electron-main: ${process.env.SLACK_CLIENT_ID}`);
135-
logEverywhere(`process.env.SLACK_CLIENT_SECRET in electron-main: ${process.env.SLACK_CLIENT_SECRET}`);
134+
// logEverywhere(`process.env.SLACK_CLIENT_ID in electron-main: ${process.env.SLACK_CLIENT_ID}`);
135+
// logEverywhere(`process.env.SLACK_CLIENT_SECRET in electron-main: ${process.env.SLACK_CLIENT_SECRET}`);
136136

137137
return deeplink.on("received", link => {
138138
logEverywhere(`auth worked here link: ${link}`);

0 commit comments

Comments
 (0)